Repository navigation
refactor(changelog)!: adopt pinned shared changelog commands - #262
Closed
acgetchell wants to merge 3 commits into
Closed
acgetchell wants to merge 3 commits into
acgetchell wants to merge 3 commits into
Conversation
- Delegate generation, normalization, minor archiving, release notes and local tag preparation to the published research-repo-tools 0.1.7 CLI. - Preserve retained release history and dependency-note links while moving completed series to docs/archives/changelog. - Keep the historical git-cliff policy as a documented consumer exception and validate published changelog links alongside the shared checks. BREAKING CHANGE: changelog-unreleased now requires TAG DATE and leaves release metadata preparation separate. Replace the removed standalone archive-changelog, postprocess-changelog and tag-release entry points with research-repo-tools changelog commands. Tags must use v-prefixed SemVer; tagging requires today's UTC release date matching CITATION.cff. Refs #254
- Forward preview options to the shared CLI and keep generated archives under the dedicated changelog formatter and final link check. - Accept valid included dependency groups while advancing only direct dev pins, leaving the shared tooling dependency under its own upgrade policy. - Keep declared release dates valid after a later merge and include canonical changelog archives in the release staging guidance. Refs #254
- Pin the synthetic Cargo identity independently of the checkout's release version while retaining the real consumer configuration and policy. - Disable inherited commit and tag signing only inside disposable repositories so fixture operations do not require user signing keys. Refs #254
Contributor
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: acgetchell/la-stack/.coderabbit.yaml Review profile: CHILL Plan: Essentials Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (25)
💤 Files with no reviewable changes (6)
Included review availability: This review used your included allowance. 2 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour. 📝 WalkthroughWalkthroughThe repository replaces local changelog and release-tag scripts with the pinned ChangesShared tooling setup
Changelog generation and archiving
Dated releases and tag operations
Archive paths and repository checks
Priority: ➖ Normal Estimated code review effort: 4 (Complex) | ~60 minutes Change: Refactor Sequence Diagram(s)sequenceDiagram
participant Maintainer
participant Justfile
participant ChangelogCLI as research-repo-tools changelog CLI
participant ReleaseFiles as CHANGELOG.md, Cargo.toml, CITATION.cff
participant Git
Maintainer->>Justfile: Run tag or tag-force
Justfile->>ChangelogCLI: Pass tag and force option
ChangelogCLI->>ReleaseFiles: Read release notes and validate version and date
ChangelogCLI->>Git: Create or replace annotated tag after validation
Git-->>ChangelogCLI: Return tag operation result
Merge Risk: ⚪ Minimal · up to The shared changelog migration has no identified merge-blocking issue. Explicit release dates and the new archive paths are consistently reflected in the documented workflows; normal checks and owner approval remain appropriate. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Owner
Author
|
@coderabbitai full review Please review all changes on this clean changelog-phase draft at exact commit 2372f81. This independent branch preserves PR #261 and its external tool/dependency refresh. Keep this PR as a draft for Adam's approval. |
Contributor
✅ Action performedFull review finished. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repository duplicates changelog normalization, minor-series archives and tag preparation. This first phase delegates those commands to the exact published
research-repo-tools==0.1.7, locked intoolingand included bydev. It removes the three exclusive Python implementations and their tests after baseline and parity checks.Thin recipes cover generation, a read-only preview with actual argument forwarding, explicit-date prospective releases, archiving, whole-history checks, root/archive notes and local tags. Completed series move to
docs/archives/changelog/MAJOR.MINOR.md. Dedicated checks apply the normal Markdown/link policy to published history; generic Markdown formatting leaves generated changelogs alone.The retained
cliff.tomlis a documented consumer exception under #254: packaged policy suppresses historicalchore(deps-dev)bodies containing Ruff/Ty/setuptools release-note, changelog and comparison links. Candidate formatting inherits repository policy and suppresses MD057 only before future archive files exist; final checks retain link validation.changelog-unreleased TAG DATEnow requires an explicit ISO date and keeps metadata preparation separate. Removed standalone entry points are replaced byresearch-repo-tools changelog. Tags require v-prefixed SemVer and a declared release-heading date matching citation metadata, preserving tagging after a later-day merge. The existing updater accepts valid include-group declarations while updating directdevpins and retaining the exact included tooling pin and lock behavior.Validation of exact head
2372f81639838b4f3a767ff021c3ca766aaba63e:just changelog-checkpasses all four published files. An isolated real uv update preserves the included tooling pin, other manifest values and lockfile bytes.just checkand the single finaljust ciwere executed. Both stopped at the online zizmor GitHub advisory audit because cloud API access failed; the public endpoint independently returns 403. Reached Rust/Python/document/config checks pass. The separate full native Python suite passes after CI's early stop.This clean phase branch publishes the reviewed source independently. PR #261 and its external dependency/tool refresh commit
8a062083are preserved unchanged.Rust/scientific/benchmark/performance implementation and num-bigint/num-rational exclusions remain unchanged. Shared setup/toolchain/maintenance migration stays deferred; updater changes are limited to include-group compatibility. The released installation contract uses existing uv plus shared setup when that later phase is adopted; this phase adds no generated bootstrap installers or future v0.1.8 capabilities.
Refs #254. Keep this PR in DRAFT for Adam's approval and CodeRabbit review; do not merge or enable auto-merge.
Summary by CodeRabbit
New Features
Improvements
Documentation