Skip to content

fix: repair release recipe approval and notes output - #286

Merged
acgetchell merged 1 commit into
mainfrom
fix/release-publish-recipe
Oct 17, 2026
Merged

acgetchell merged 1 commit into
mainfrom
fix/release-publish-recipe

Conversation

@acgetchell

@acgetchell acgetchell commented Oct 17, 2026 •

Copy link
Copy Markdown
Owner

just release-publish failed because it omitted the shared CLI's required --approve flag, and redirecting just release-notes captured a uv setup diagnostic in the release body. Forward explicit approval and send prerequisite diagnostics to stderr, with regressions covering both commands.

Also apply the post-v0.5.0 libc 0.2.191 and managed rumdl 0.3.0 updates, and sort the README design goals without changing their wording.

Validation:

  • Astra reviewed all five changed files and found no actionable issues.
  • just lint-config passed on the reviewed source.
  • Python formatting, lint, typing, and all 181 tests passed.
  • just markdown-fix markdown-ci passed, including spelling.
  • Native Linux/macOS/Windows PR checks remain pending.

The existing v0.5.0 tag and published benchmark evidence are preserved. No benchmark measurements were rerun.

Summary by CodeRabbit

  • Chores
    • Release publishing now requests explicit approval. Setup diagnostics are directed to stderr so they don’t appear alongside generated release notes.
    • Updated the configured Markdown-checking tool version.
  • Documentation
    • Reordered the Design goals list; its listed capabilities remain unchanged.
  • Tests
    • Added checks for release-note output separation and explicit approval during publishing.

- Pass explicit approval when publishing a reviewed release draft.
- Send uv prerequisite diagnostics to stderr so generated notes stay clean.
- Update libc to 0.2.191 and the managed rumdl pin to 0.3.0 after v0.5.0.
- Sort the README design goals lexicographically.
@acgetchell
acgetchell enabled auto-merge (squash) October 17, 2026 09:48
@coderabbitai

coderabbitai Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: acgetchell/la-stack/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 2eadc6b8-cace-4372-b6b8-0c1e1ee5e02b
📥 Commits

Reviewing files that changed from the base of the PR and between 5d8f5b4 and d94122b.

⛔ Files ignored due to path filters: 1
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing: 4
  • README.md
  • justfile
  • pyproject.toml
  • scripts/tests/test_release_publishing.py

Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

📝 Walkthrough

The release recipes now redirect dependency-check output to stderr and pass explicit approval when publishing. Tests cover both changes. The README reorders two design goals, and the configured rumdl version changes to 0.3.0.

Changes: Release recipe behavior

Layer / File(s) Summary
Release recipe behavior and tests
justfile, scripts/tests/test_release_publishing.py
The dependency check’s output goes to stderr. The publish recipe passes --approve. Tests check output streams and publish command dispatch.

README design goals

Layer / File(s) Summary
Design goal ordering
README.md
The interval-expression and determinant-sign goal now appears before the vector-norm goal. The wording is unchanged.

rumdl version

Layer / File(s) Summary
Configured rumdl version
pyproject.toml
The configured rumdl version changes from 0.2.79 to 0.3.0.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to d9412

No identified issue prevents merging after the pending native checks complete.

Pre-merge checks: Passed 4
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely identifies both main changes: release approval handling and release notes output.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@acgetchell acgetchell self-assigned this Oct 17, 2026
@codecov

codecov Bot commented Oct 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.14%. Comparing base (5d8f5b4) to head (d94122b).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #286      +/-   ##
==========================================
+ Coverage   98.11%   98.14%   +0.02%     
==========================================
  Files          14       14              
  Lines        7160     7160              
==========================================
+ Hits         7025     7027       +2     
+ Misses        135      133       -2     
Flag Coverage Δ
unittests 98.14% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@acgetchell
acgetchell merged commit b2ad940 into main Oct 17, 2026
21 checks passed
@acgetchell
acgetchell deleted the fix/release-publish-recipe branch October 17, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant