Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Importing
csv-stringify/browser/esmpulls Node ambient types into DOM projects, changingsetTimeoutfromnumbertoNodeJS.Timeout.Generate browser declarations against the bundled stream and Buffer contracts, keeping CSV options and overloads in one source. Preserve Node ESM, CommonJS and legacy resolution. Fixes #476.
Validation: the original DOM reproduction fails before and passes after; isolated DOM/Node type checks, Rollup, lint and formatting pass. On Windows, 191 runtime tests pass with one existing pending test; the sample and pipe suites are excluded for their existing file-URL and
/tmppath failures.