Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a handler throws,
stream-transform/synccurrently returns partial results, processes later records, and then emits an unhandled error from its internal stream. Atry/catcharoundtransform()cannot catch the original failure.Make the sync adapter throw the original error immediately by overriding its local error path, alongside the existing
pushoverride. The regression checks error identity and that later records are skipped. The stream and callback APIs retain their existing error handling.Validation:
Missing expected exceptionand passes with the fix.git diff --checkpass.