Repository navigation
Fix cookie domain for qc.ca and other multi-label public suffixes - #4
Merged
Merged
Conversation
simcamadd
force-pushed
the
fix/cookie-domain-public-suffixes
branch
from
October 8, 2026 07:51
288cff7 to
30bcd67
Compare
getMainDomain() did not know provincial Canadian suffixes, so for www.ithq.qc.ca the cookie was set with domain=qc.ca and rejected by browsers. Add Canadian provinces/territories and other common multi-label public suffixes.
simcamadd
force-pushed
the
fix/cookie-domain-public-suffixes
branch
from
October 8, 2026 07:56
30bcd67 to
165520e
Compare
WFrancois
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Customer report on www.ithq.qc.ca:
admin-ajax.phpanswered "Cookie set successfully" but theSet-Cookieheader containeddomain=qc.ca, a public suffix, so Chrome rejected the cookie (invalid Domain attribute). The composed TLD list only hadgc.ca/gov.ca.Changes
Only the
$composedTldslist ingetMainDomain()is changed:ab.ca,bc.ca,mb.ca,nb.ca,nf.ca,nl.ca,ns.ca,nt.ca,nu.ca,on.ca,pe.ca,qc.ca,sk.ca,yk.ca.All added entries were checked against the official Public Suffix List.
Testing
Plugin handler run on PHP 5.6 and 8.3 (Docker, stubbed WordPress), reading the actual
Set-Cookieheader:www.ithq.qc.ca→domain=ithq.qc.ca(wasqc.ca)www.example.com.co→domain=example.com.co(wascom.co)www.example.fr,shop.example.co.uk→ unchangedphp -lOKFollow-ups (not in this PR)