Repository navigation
Conversation
chirokas
marked this pull request as ready for review
September 24, 2026 10:07
chirokas
force-pushed
the
combobox-shadow-portal
branch
2 times, most recently
from
September 27, 2026 09:17
39ce6c9 to
ed4713a
Compare
chirokas
force-pushed
the
combobox-shadow-portal
branch
from
October 21, 2026 14:52
ed4713a to
ccb9f50
Compare
Contributor
|
@snowystinger LGTM |
snowystinger
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
When ComboBoxInput and Popover are rendered in separate shadow DOM trees,
opening the popover via keyboard fails because the relatedTarget of the
virtualBlur event gets retargeted to the nearest shadow-including ancestor,
causing the popover to close unexpectedly.
This fix ensures keyboard interaction works correctly even when the components
don't share the same shadow root.
New.project.mp4
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: