Repository navigation
chore: move type guards - #10832
Merged
Merged
chore: move type guards#10832
Conversation
snowystinger
approved these changes
Oct 23, 2026
snowystinger
added
small review
| isShadowRoot | ||
| } from '../../../src/utils/domHelpers'; | ||
| export {addEvent, getOwnerDocument, getOwnerWindow} from '../../../src/utils/domHelpers'; | ||
| export {isDocument, isShadowRoot} from '../../../src/utils/typeHelpers'; |
Member
There was a problem hiding this comment.
Not strictly necessary, but I think it's a nice bit of reorganisation. Technically theses are on private paths, so we could just omit them from re-export here, but this seems like a nice thing to do
reidbarber
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RE: #10556 (comment)
Splits chores from scroll utils PR to aid with review. [2/3]
✅ Pull Request Checklist:
📝 Test Instructions:
N/A
🧢 Your Project:
N/A