Skip to content

chore: add shadow-safe parent lint rules - #10834

Merged
reidbarber merged 2 commits into
adobe:mainfrom
nwidynski:chore-shadow-parent
Oct 27, 2026
Merged

reidbarber merged 2 commits into
adobe:mainfrom
nwidynski:chore-shadow-parent

Conversation

@nwidynski

Copy link
Copy Markdown
Contributor

RE: #10556 (comment)

Splits chores from scroll utils PR to aid with review. [3/3]

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices
  • I understand every change in this PR and can explain why it's there.
  • If AI-assisted, I followed our AI contribution guidance and pointed my assistant at AGENTS.md.

📝 Test Instructions:

N/A

🧢 Your Project:

N/A

snowystinger
snowystinger previously approved these changes Oct 22, 2026

@snowystinger snowystinger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

LFDanLu
LFDanLu previously approved these changes Oct 23, 2026
# Conflicts:
#	packages/react-aria/src/interactions/utils.ts
#	packages/react-aria/src/overlays/ariaHideOutside.ts
#	packages/react-aria/src/utils/domHelpers.ts
#	packages/react-aria/src/utils/shadowdom/DOMFunctions.ts
@nwidynski
nwidynski dismissed stale reviews from LFDanLu and snowystinger via 93db71f October 24, 2026 17:21
@reidbarber
reidbarber added this pull request to the merge queue Oct 27, 2026
Merged via the queue into adobe:main with commit 3280ed4 Oct 27, 2026
30 checks passed
@nwidynski
nwidynski deleted the chore-shadow-parent branch October 27, 2026 19:41
@yihuiliao yihuiliao added the no testing Does not require manual testing during testing session label Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants