Repository navigation
IR-295: source-bind Kani form settlement - #354
Merged
Merged
Conversation
kreneskyp
force-pushed
the
codex/kani-form-settlement
branch
3 times, most recently
from
October 11, 2026 19:25
a035339 to
18f9a91
Compare
added 10 commits
October 12, 2026 08:09
kreneskyp
force-pushed
the
codex/kani-form-settlement
branch
from
October 12, 2026 15:39
88d4e67 to
6ae3a61
Compare
added 6 commits
October 12, 2026 08:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs IR-295
This change source-binds Kani form settlement to typed IR forms before capability negotiation reports Supported. It gives V2 function applications stable refusal identities and verifies the source callee plus ordered arguments. The function generator receives body-expression roots and call-item roots from one admitted ContractPackageV1; source declaration IDs remain distinct for exact call binding.
Current head:
6618b8c062977064a06ae18679304c3d5573703f, based onmain6531d982ff432a28545a872d29fe3ef53ff04eb6.Focused receipts on this candidate:
cargo fmt --all -- --check: PASS.git diff --check: PASS.Combined focused log:
/tmp/ir295-pr354-13-focused-cb0f474-final.log; corrected ambiguity retest:/tmp/ir295-pr354-ambiguous-e_tuple-cb0f474.log. Commands usedQSPEC_DIR=/home/peter/dev/quire-specification,CARGO_HOME=/tmp/ir295-pr354-cargo-home, and target/home/peter/dev/quire-contract-codegen-ir295-pr354/target/ir295-pr354-clean-cb0f474.The ordinary corpus now gives scalar roots a checked
quire.op.integer.addoperation and Integer result; FN_EQ remains an equality root and call roots retain their existing form. This preserves the 14-application-root construction and its admission/accounting assertions. The resolved canonical ext-corpus package measures 264,645 bytes, below the 1 MiB reader cap. The prior 156,857-byte figure was stale and is superseded by this measured value. No cap or acceptance assertion was weakened.AC-11 retains typed Model/State lowering-family blockers and valid V2 source calls. AC-27 source-binding checks remain separate, including body-root/declaration-ID distinction, wrong-callee discrimination, and ordered arguments. The scalar body classifier now checks its declared arithmetic operator against the checked operation identity and returns BodyMismatch on disagreement.
The obsolete MAX_CALL_DEPTH chain selector and generated chain fixture were removed. AC-7 coverage is the flat 100K-call SSA schedule test only. AC-34 remains Planned; this PR claims neither AC-34 nor runtime call-depth coverage.
Reviewer artifacts are committed at this head: code review and gap analysis. FND-003 and FND-004 are fixed; the latest delta review records FND-005 and FND-006 fixed with no new findings.
Aggregate gate history: Pair 1
make -k ciwas red on pre-fix headcb0f47414afa6137fce86cbabd5e929eb903648f(exit 2), log/tmp/ir295-pr354-clean-ci-cb0f474.log. MSRV and regular integration runs each reported the same 11 failures (517 passed, 11 failed, 27 ignored); AC-7 flat 100K and AC-34 strict-reader chain passed in those runs. The focused fixes above are green, but aggregate CI has not been rerun on this head. Kani was skipped because CI was red and has not run on this head. Both aggregate CI and Kani remain pending.