Repository navigation
IR-550: cover admitted direct fairness refusal - #373
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the IR-550 direct fairness slice by exercising an IR-admitted
temporal/fairnessnode as the requested call-node ID in the public exact-function generator. The test builds the package from the authoritative QSpec positive fixture at runtime; it does not copy a temporary QSpec or IR package into the repository.The focused test verifies:
CheckedPackageV2::readpath with the same evidence.Unsupportedwith the fairness node ID andtemporaltag as its cause.src/lib.rs, and location map are byte-identical when run alone or alongside the fairness request.body.operation.lawsis refused at/semantic_graph/nodes/0/body; the builder now avoids mutating absent keys.Review and gates
make -k ci: PASS on07adadcc30b4b3505f26efdce5b638354f1d4a5b; 247 unit tests, 508 integration tests passed, 27 ignored, 1 doctest passed. Log:/tmp/ir550-prepr-ci-07adadcc.log.make kani-gate: PASS, 27/27 on the same head. Log:/tmp/ir550-prepr-kani-07adadcc.log.make -k ci: PASS on the unchanged clean head; MSRV and stable each passed 247 unit tests, 508 integration tests with 27 expected ignored, and 1 doctest; fmt, spec, lint, deny, unsafe audit, and rustdoc passed. Log:/tmp/ir550-premerge-ci-07adadcc.log.make kani-gate: PASS, 27/27 on the unchanged clean head with Kani 0.68.0 and CBMC 6.11.0. Log:/tmp/ir550-premerge-kani-07adadcc.log.Together with merged PR #372, this closes the remaining direct fairness criterion in IR-550. IR-550 and the supporting IR-774 admission investigation can close after this merge is verified.
Refs IR-550