Skip to content

fix: correct X11 text input and release v0.7.15 - #250

Merged
avifenesh merged 1 commit into
mainfrom
fix/x11-text-feedback
Oct 10, 2026
Merged

avifenesh merged 1 commit into
mainfrom
fix/x11-text-feedback

Conversation

@avifenesh

@avifenesh avifenesh commented Oct 10, 2026 •

Copy link
Copy Markdown
Collaborator

X11 typing lost LF newlines in editors and gave false failure feedback for terminals. The xdotool path now sends LF and CRLF as Return, with one Return per CRLF pair. AT-SPI terminal focus is a valid keyboard target even without EditableText. Non-terminal warnings remain. Input timing and no-replay fallback rules are unchanged.

Validation: all 440 Rust tests, all-target Clippy, formatting, MCP safety, plugin/catalog and npm package checks passed. Both new regressions failed before the fix. Tests through the real MCP server on private Xvfb, Openbox, GTK 3 and VTE reproduced both reports: baseline L1\nL2\n became L1L2, and a terminal command executed while carrying the false warning. The patch preserves editor line breaks, keeps CRLF as one newline, and removes the terminal false warning.

Also prepares v0.7.15 across Cargo, npm, MCP, Pi and plugin surfaces, plus the changelog. Fresh-context subagent review found no actionable issues. CI is in progress.

Fixes #246.
Fixes #247.

Signed-off-by: Avi Fenesh <aviarchi1994@gmail.com>
@cursor

cursor Bot commented Oct 10, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: 4a80b001-b91e-424d-a1d7-68bd6ab63006)

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Cursor Bugbot was skipped (usage limit), so that signal was ignored; no applicable approval policy requires human review, and this automation has no prior approval to re-evaluate. No reviewers were assigned.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver

@avifenesh

Copy link
Copy Markdown
Collaborator Author

Fresh-context subagent self-review: no actionable findings.

CUL head 13dce73: terminal feedback uses enum-derived AT-SPI identity. CRLF folding precedes LF conversion. The original fallback text and no-replay behavior are preserved. Cargo, npm, MCP, Pi and plugin versions agree at 0.7.15.

Codex head 454265a5: the COSMIC helper and fixture match upstream after binary-name mapping. Branding, identity, Chrome, avatar and input guard code are preserved.

The reviewer checked both immutable diffs, whitespace and plugin metadata. It did not independently rerun the full suites or a live COSMIC compositor. My local validation passed 440 standalone and 539 embedded Rust tests, Clippy, 20 adjacent Node tests, and the real standalone X11 MCP scenarios on an isolated GTK/VTE desktop.

@revuto-review revuto-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an auto review done by revuto.


Revuto completed the review and found no evidence-backed concerns.

@avifenesh
avifenesh merged commit 7b9ddd0 into main Oct 10, 2026
26 checks passed
@avifenesh
avifenesh deleted the fix/x11-text-feedback branch October 10, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant