Skip to content

fix(kwin): replace unstable atomic_try_update with stable fetch_add #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avifenesh merged 1 commit into from
Oct 12, 2026
Merged

fix(kwin): replace unstable atomic_try_update with stable fetch_add #252

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions src/windowing/backends/kwin.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,11 +423,14 @@ impl KwinWindowCallback {

fn temporary_kwin_plugin_name() -> Result<String> {
let pid = std::process::id();
let sequence = KWIN_PLUGIN_SEQUENCE
.try_update(Ordering::Relaxed, Ordering::Relaxed, |value| {
value.checked_add(1)
})
.map_err(|_| anyhow::anyhow!("temporary KWin plugin sequence exhausted"))?;
// Stable equivalent of `AtomicU64::try_update(.., checked_add)`. `fetch_add`
// returns the previous value and `checked_add` on it reproduces exactly the
// overflow condition the closure existed to detect, using stable primitives
// only. `try_update` was the sole unstable-library usage in this crate.
let previous = KWIN_PLUGIN_SEQUENCE.fetch_add(1, Ordering::Relaxed);
let sequence = previous
.checked_add(1)
.ok_or_else(|| anyhow::anyhow!("temporary KWin plugin sequence exhausted"))?;
let mut nonce = [0_u8; 16];
getrandom::fill(&mut nonce).map_err(|error| {
anyhow::anyhow!("failed to generate temporary KWin plugin nonce: {error}")
Expand Down
Loading