Skip to content

Rename some ExternalVolume fields - #2404

Merged
Julian Gutierrez Oschmann (juli4n) merged 2 commits into
agent-substrate:mainfrom
juli4n:rename_volume_name
Oct 9, 2026
Merged

Rename some ExternalVolume fields#2404
Julian Gutierrez Oschmann (juli4n) merged 2 commits into
agent-substrate:mainfrom
juli4n:rename_volume_name

Conversation

@juli4n

@juli4n Julian Gutierrez Oschmann (juli4n) commented Oct 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Naming the field volume_name is redundant. Rename to to name.

Also rename actor_volumes to external_volumes.

Part of #1378

@juli4n
Julian Gutierrez Oschmann (juli4n) marked this pull request as ready for review October 9, 2026 14:14
@juli4n Julian Gutierrez Oschmann (juli4n) changed the title Rename ExternalVolume.volume_name to name. Rename some ExternalVolume fields Oct 9, 2026
@juli4n
Rename ExternalVolume.volume_name to name.
fbad9d4
@juli4n
Rename actor_volumes to external_volumes.
d787556 
The `actor` prefix is redundant. External is also better as it
reflects what type of volume this is referring to.
Merged via the queue into agent-substrate:main with commit 75e7f8b Oct 9, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msau42 Michelle Au (msau42) msau42 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@juli4n @msau42