Repository navigation
Remove the legacy Miles engine - #252
Merged
Merged
Conversation
michaellchung
force-pushed
the
s23-pr-10-repo-hygiene
branch
from
October 14, 2026 11:31
e4b607c to
83a2926
Compare
…as an alias The preset names the full-parameter transport, not which parameters train: DeepSeek V4 expert-full rides it too (P0-1.7b.2-Q2). Both the CLI --rl-sync-preset and the island --sync-preset resolve the old name through selection.canonical_sync_preset, so commands and syncers only ever see the new name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
verify_miles_revision and miles_execution_source_sha256 move to adapters/miles/revision.py (default pins: MILES_NEXT_PINS); the ports composition root writes tape events through engine.events.append_tape_event instead of the legacy engine's re-export. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…1.10) Delete yeto/rl/adapters/miles/legacy/ and models/rollout_legacy_port.py, their only callers being the legacy translation (_legacy_miles_argv, build_miles_argv) and the yeto_policy_sync external-hook path of the island entry. With them go: the agentenv pins (MILES_COMMIT, MILES_BASE_COMMIT, bundle, MILES_IMAGE, MILES_LEGACY_PINS, SGLANG_COMMIT) and the vendored bundles, the external SGLang router, the before-train-step LR/grad-audit hooks, the legacy DSV4 runtime switches, publish._policy_token, the teacher-forcing legacy token and every rl_engine branch in the launcher, SSH harness, export, benchmark and run config. --rl-engine keeps parsing but accepts only ports and is no longer forwarded. backend_identity() takes no engine. The SecRLEnv rollout errors move into harness/codex/reward.py. The launcher reads the Miles overlay through the backend registry (role 'overlay'), so the import allowlist drops to 8 entries; a new check forbids importing the removed modules. selection.ports_rejections keeps only combinations no engine runs, each with its reason, and no longer points at --rl-engine legacy. Legacy-only tests are deleted (old test runs do not resume, P0-D5); the rest are moved to the ports path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
michaellchung
marked this pull request as ready for review
October 14, 2026 11:31
michaellchung
force-pushed
the
s23-pr-11-remove-legacy-engine
branch
from
October 14, 2026 11:31
0cb2801 to
5637d41
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deletes
yeto/rl/adapters/miles/legacy/androllout_legacy_port.py(about 9.3k lines) and everyrl_enginebranch; ports is the only Miles engine.Motivation
rl-code-quality-cleanup 1.7b.4, 1.8, 1.10. All workloads (LoRA, dense, SAO, DSV4) now run on ports (PRs 01-05).
What changed
dense-full->full-parameter;dense-fullstays an alias (P0-1.7b.2-Q2).adapters/miles/revision.py; tape writes viaengine.events.MILES_COMMIT,MILES_IMAGE,SGLANG_COMMIT, ...), vendored bundles, external SGLang router, legacy DSV4 switches. Launcher reads the overlay through the backend registry; import allowlist drops to 8 entries (P0-W).Behavior changes / compatibility
--rl-enginestill parses but accepts onlyportsand is no longer forwarded (full removal is a follow-up).backend_identity()takes no engine argument. Old test runs do not resume (P0-D5).Tests
Local CPU tests: every test file this PR adds or changes: 3 failed, 1189 passed, 6 skipped, 5 deselected, 6 warnings in 146.36s (0:02:26). The failure(s) are in the expected set below.
Known expected failures until the ports image is rebuilt for the new Miles pin (P0-1.11 GPU run):
test_rl_ports_image(2),test_rl_backend_identity::test_golden_samples_keep_both_old_hashes_and_carry_the_identity, and 8test_decoupling_goldensamples (golden is regenerated after the rebuild).Depends on
#251.
Not verified on GPU
None of this PR has run on GPU yet. The regression GPU run for the S23 stack is P0-1.11 GPU run (in progress at the time of writing); results will be linked here before merge.
🤖 Generated with Claude Code