Repository navigation
S25-C: resume manifest assertions for cut restore (N7.6) - #271
Draft
michaellchung wants to merge 1 commit into
Draft
michaellchung wants to merge 1 commit into
michaellchung wants to merge 1 commit into
Conversation
…S25 N7.6) A-TRN report #8: restoring optimizer state on PPU can silently reset the Adam step. A cut now records a backend-neutral resume manifest (Adam step per group, LR scheduler progress and applied LRs, exp_avg/exp_avg_sq norm and sha256 of fixed sampled parameters, global step, data watermark). After loading, every rank must match it; after the first step every counter must advance by exactly the steps taken. Any mismatch raises ResumeAssertionError (a CutError); a cut without the manifest is refused. - yeto/rl/engine/resume_manifest.py: neutral types, checks, file form, torch.optim reader (FSDP2 DTensor local shards). - Miles: cut shards report the rank state; save_cut embeds the manifest, restore_cut checks it before the digest comparison, the first train_step after a restore checks the advance. - verl/FSDP2: worker binding (actor_module_fsdp/actor_optimizer/ actor_lr_scheduler). - CPU tests: train 3 + save + resume 2 equals train 5 (torch and FSDP2 over gloo, 2 ranks); reset step, partial reset, fresh moments, reset scheduler and a non-advancing first step are all refused. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing: Full remote test suite on the stack tip: 0 failures. Not validated on PPU/NPU hardware (machines busy).
Part of the S25 stack (NPU+PPU heterogeneous GLM5.3-Flash full-param RL). Draft; do not merge before the S24 stack (#262–#268).
🤖 Generated with Claude Code