Skip to content

docs(examples/minimal): pin real root key, align enforcement mode, and add unit test (fixes #218) - #220

Merged
imran-siddique merged 5 commits into
agentrust-io:mainfrom
aipd506:fix/minimal-example-readme-and-test
Oct 1, 2026
Merged

imran-siddique merged 5 commits into
agentrust-io:mainfrom
aipd506:fix/minimal-example-readme-and-test

Conversation

@aipd506

@aipd506 aipd506 commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

Fixes #218

Summary of Changes

This PR aligns examples/minimal/README.md with the committed configuration and adds test coverage for the minimal example commands:

  1. examples/minimal/README.md Corrections:

    • Replaced <trusted-root-issuer-hex> placeholder on line 14 with the actual pinned trusted root issuer public key (eda38c446da3db3eba68852ca9869260c36badd48b2cab16ec8d8faf607eb162) defined in ca2a-config.yaml.
    • Updated the description of ca2a-config.yaml on line 7 from (software-only, advisory) to (software-only, enforcing) to match the configured enforcement_mode: enforcing.
  2. New Unit Test Suite (tests/unit/test_example_minimal.py):

    • Tests ca2a verify-chain against examples/minimal/chain.json with the pinned root key, asserting verified: True, hops: 3, and leaf_scope: ["cap:read"].
    • Tests ca2a validate-config against examples/minimal/ca2a-config.yaml, asserting exit code 0 and output ok: provider=software-only enforcement=enforcing.

Verification

  • Offline chain verification passes with the pinned key.
  • Config validation output matches the documented string.

@aipd506
aipd506 requested review from a team, carloshvp and zohebk8s as code owners September 30, 2026 16:46
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for this, @aipd506. Closing it for now, and it is not about the change itself.

This repository asks first-time contributors to be vouched by a maintainer before opening a pull request. That is because agent-written contributions are easy to produce and expensive to review, and we would rather talk to you first than review something neither of us can explain.

To get vouched: open an issue saying what you want to change and why, in your own words. A maintainer will reply, and add you with /vouch. After that, reopen this pull request or open a new one.

See CONTRIBUTING.md for the detail.

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@imran-siddique
imran-siddique merged commit b607685 into agentrust-io:main Oct 1, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

examples/minimal README: placeholder root key, and "advisory" contradicts the config

3 participants