Repository navigation
Let codex retry a turn the overlay dropped - #199
Merged
Merged
Conversation
A turn reaches the platform over the overlay, and a connection that served one turn may be gone by the next: the tunnel closes its circuit and the following request goes into it before anything notices. With no retries at all that was fatal -- the tool call ran, and the turn that should have reported what it found died on the way out with nothing posted to the thread. The zeros were set to match what the e2e config had, which is a reason to make a test deterministic and not a reason for an agent in a cluster to give up on its first dropped connection.
This was referenced Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
request_max_retriesandstream_max_retrieswere both 0, set to "align runtime Codex provider config with E2E config" — a reason to make a test deterministic, not a reason for an agent in a cluster to give up on its first dropped connection.Codex reaches the proxy over the overlay. A connection that served one turn may be gone by the next: the tunnel closes its circuit and the following request goes into it before anything notices. Observed on the local VM in
TestMCPToolsE2E— codex completes its first turn, the MCP tool call reaches the sidecar, and the turn that should report the result dies immediately after:Two is small enough that a provider genuinely refusing is still reported rather than hammered.