Skip to content

fix(ui): stop the credentials group overlapping network endpoints - #139

Merged
Gkrumbach07 merged 1 commit into
ai-openshell:mainfrom
Gkrumbach07:claude/fix-132-profile-form-layout-39f626
Nov 18, 2026
Merged

Gkrumbach07 merged 1 commit into
ai-openshell:mainfrom
Gkrumbach07:claude/fix-132-profile-form-layout-39f626

Conversation

@Gkrumbach07

@Gkrumbach07 Gkrumbach07 commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #132

Root cause

In the Create provider profile modal, each credential row was wrapped in its own one-item PatternFly Stack. The Stack layout sets height: 100%. The Form is a CSS grid, so the grid row of the Credentials group is first sized from its content (row + "Add credential" + helper text, 88px for the control). The form group control is then stretched to that definite height, and the Stack's 100% resolves against it. The Stack takes the whole 88px, which is the blank gap under the row. The "Add credential" link and the helper text that follow it overflow the group by about 50px and land on the "Network endpoints" label.

The endpoint rows are bare Grids, so the Network endpoints group was never affected.

Fix

Each credential row is now a bare Grid, like the endpoint rows. The one-item Stack/StackItem wrapper added nothing, and the data-testids are unchanged.

Verification

  • Reproduced in make dev-mock at 1280×1000, Create profile → Add credential: the overlap from the issue screenshot appears.
  • After the fix, with two credential rows and one endpoint row, every form group's content stays inside its own bounds (measured in the DOM), and the screenshot shows no overlap or gap.
  • npm run lint, format:check, make typecheck, and CreateProfileModal.spec.tsx (6) plus ProfilesPanel.spec.tsx (15) all pass. No Go code changed.

Screenshots

Create profile → Add credential, at 1280×1000 (make dev-mock).

Before After (two credential rows, one endpoint row)
before after

🤖 Generated with Claude Code

Each credential row in the Create provider profile modal was wrapped in
its own one-item PatternFly Stack. The Stack layout sets height: 100%,
and inside the Form's CSS grid the form group control is stretched to
a definite height, so the Stack filled the whole control (the blank gap
under the row) and pushed the "Add credential" link and its helper text
out of the group, over the "Network endpoints" label.

Render each credential row as a bare Grid, as the endpoint rows already
are.

Fixes ai-openshell#132

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Gage Krumbach <gkrumbac@redhat.com>

@danreed-rh danreed-rh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Gkrumbach07
Gkrumbach07 merged commit b15816c into ai-openshell:main Nov 18, 2026
15 checks passed
@Gkrumbach07
Gkrumbach07 deleted the claude/fix-132-profile-form-layout-39f626 branch November 18, 2026 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provider profile creation text

2 participants