You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
test(sandbox): terminal_group_signal_precedes_the_first_descendant_collect fails on 4-vCPU runners #5811
I maintain OpenShell CI. While moving Branch Checks to standard GitHub-hosted runners (#4554), I hit a sandbox unit test that fails there but passes on the old 8-core runners, so the Rust test jobs cannot go green.
Description
openshell-sandbox boundary_io::tests::terminal_group_signal_precedes_the_first_descendant_collect (crates/openshell-sandbox/src/boundary_io.rs) fails on 4-vCPU GitHub-hosted runners:
thread 'boundary_io::tests::terminal_group_signal_precedes_the_first_descendant_collect' panicked at crates/openshell-sandbox/src/boundary_io.rs:1514:13:
the registered group must be signaled before the first descendant collect returns
Runner
Result
NVIDIA linux-amd64-cpu8 / linux-arm64-cpu8 (every run since #5217)
The test signals the registered process group with SIGSTOP from a second thread, parks the first /proc descendant collect through the collect hook, and then gives the root process 2 seconds to show as stopped. Because it passes intermittently on arm and never on 4-core x86, this looks like a race in the test rather than a product bug: if a collect other than the signal path's reaches the hook first and parks while holding a lock the signal path needs, SIGSTOP is not sent before the 2-second deadline. That hypothesis is unconfirmed.
Context
The test is marked #[ignore] so the CI move can land. It was added in #5217.
Definition of Done
The race is understood, and the test or the code it covers is fixed so it passes reliably on 4-vCPU runners.
Activity
test(sandbox): ignore a signal-ordering test that races on 4-vCPU run…
test(sandbox): ignore a signal-ordering test that races on 4-vCPU run…
ci: run Linux jobs on standard GitHub-hosted runners (#5799)
test(sandbox): exec the root sleep in the terminal SIGSTOP test (ai-o…