Repository navigation
Description
User Story
I maintain OpenShell and open PRs against ai-openshell/OpenShell. When automatic reviewer assignment breaks, I need my PR's checks to stay green, so that a red check reflects the PR rather than the review-routing setup.
Problem Statement
The "OpenShell / Review Readiness" check fails the PR when the reviewer request API call fails. check_review_readiness.py sends the selected reviewers in one POST .../requested_reviewers call. Any CalledProcessError from that call reaches main(), which reports an ::error annotation and exits 1.
On #5834 (area:runtime, topic:testing), GitHub rejected the request with HTTP 422: "Reviews may only be requested from collaborators." Three topic:testing reviewers in REVIEWERS.md are not collaborators on ai-openshell/OpenShell since the repository moved. #5550 addresses that roster eligibility problem. This issue covers how the check behaves when assignment fails for any reason.
Impact / Why This Matters
- The PR author sees a failed check they can't fix from their branch.
- GitHub rejects the whole batch, so none of the eligible reviewers were requested either. test(sandbox): exec the root sleep in the terminal SIGSTOP test #5834 has no review requests, though the runtime reviewers are collaborators.
- The check is not required, so merges are not blocked, but the red check adds noise during review.
Acceptance Criteria
- A failed reviewer request or removal does not fail the Review Readiness check. The workflow surfaces it as a warning annotation and step summary that names the failing call and GitHub's error message.
- Accepted-work labeling still runs and reports its result when reviewer assignment fails.
- Unit tests cover a reviewer request that returns HTTP 422.
Reproduction Steps
- Add a GitHub user who is not a collaborator on ai-openshell/OpenShell to a
REVIEWERS.mdroster. - Open a ready PR with labels that select that roster.
- The Review Readiness job fails with "Requesting reviewers failed with a GitHub API error ... (HTTP 422)" and requests no reviewers.
Environment
- OpenShell:
mainat b6e9202 - Workflow:
.github/workflows/review-readiness.ymlrunningtasks/scripts/check_review_readiness.py --apply - Failing job: 136394521689
Context
Open question: when some selected reviewers can't be requested, should the workflow retry with the eligible subset so the PR still gets reviewers? #5550's roster validation may make this rare enough not to need it.
Activity
fix(review): note reviewer assignment failures without failing the ch…