Repository navigation
Conversation
…ll/openshell#4956) * feat(services): publish authoritative application origins Signed-off-by: Taylor Mutch <taylormutch@gmail.com> * fix(services): align URL schema with separate discovery service Signed-off-by: Taylor Mutch <taylormutch@gmail.com> * fix(services): preserve replay URLs and SDK source compatibility Signed-off-by: Taylor Mutch <taylormutch@gmail.com> * docs(server): link to application URL configuration Signed-off-by: Taylor Mutch <taylormutch@gmail.com> * feat(services): allow disabling gateway application routing Signed-off-by: Taylor Mutch <taylormutch@gmail.com> * chore(server): log enabled application routing modes Signed-off-by: Taylor Mutch <taylormutch@gmail.com> * fix(helm): use canonical service routing configuration Signed-off-by: Taylor Mutch <taylormutch@gmail.com> * refactor(services): derive app listener domain from base URL Signed-off-by: Taylor Mutch <taylormutch@gmail.com> * fix(services): address application URL review feedback Signed-off-by: Taylor Mutch <taylormutch@gmail.com> * fix(supervisor): report app listener route rejections Signed-off-by: Taylor Mutch <taylormutch@gmail.com> --------- Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
ai-openshell/openshell#4956 changed core's sdk/typescript after the v0.1.9 import: SandboxRef gains applicationServiceUrls and gatewayServiceUrls. Merge the commit with its original author and sign-off, filtered with hack/migration/extract-history.sh (migration/v0.1.9) at core 90e34ad10e42c8ef76e33f913ec485dc9196f5a7. The filtered commit's parent is f4ed506, the tip of the existing import, so history is not rewritten. The change reads response fields that core adds after v0.1.9, so it compiles only with bindings generated from a core ref that includes ai-openshell/openshell#4956, such as the v0.1.10 core bump. Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
Contributor
Author
|
Superseded: porting ai-openshell/openshell#4956 with hack/migration/port-pr.sh (adapted from sdk-python) instead of a history merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ai-openshell/openshell#4956 changed core's
sdk/typescript/after the v0.1.9 import:SandboxRefgainsapplicationServiceUrlsandgatewayServiceUrls, filled fromcreateandcreateFromTemplateresponses. This PR brings that commit over with its original author and sign-off, so core can replace the directory with the re-export stub (ai-openshell/openshell#5685).Related Issue
Part of ai-openshell/openshell#5480.
Changes
fb53fb2, the core commit filtered withhack/migration/extract-history.sh(branchmigration/v0.1.9) at core90e34ad10e42c8ef76e33f913ec485dc9196f5a7. Its parent isf4ed506, the tip of the existing import, so no history is rewritten.SandboxRefadds the optionalapplicationServiceUrlsandgatewayServiceUrls. ExistingSandboxRefobjects remain valid.Merge with a merge commit, not squash, to keep the imported commit.
Testing
This branch does not type-check on its own: the change reads
SandboxResponse.applicationServiceUrlsandgatewayServiceUrls, which core added after v0.1.9. It needs bindings from a core ref that includes ai-openshell/openshell#4956, so it lands with the v0.1.10 core bump: merge this first and rebase the bump PR, or merge this into the bump branch.OPENSHELL_CORE_REFset to90e34ad10andmise run proto:gen,mise run typecheckpasses andmise run testpasses (207 tests). The pin change was not committed.mise run lintpasses.mise run typecheckfails only on the four reads of the new response fields.Checklist