Skip to content

feat(core-sync): allow pinning a core commit SHA - #20

Open
pimlock wants to merge 1 commit into
mainfrom
feat/core-sha-pin/pimlock
Open

pimlock wants to merge 1 commit into
mainfrom
feat/core-sha-pin/pimlock

Conversation

@pimlock

@pimlock pimlock commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

Summary

Allow OPENSHELL_CORE_REF to be a full commit SHA on core's main, besides a release tag. SDK support for a proto change that is on core's main but in no core tag yet can then pass CI without waiting for the next core prerelease (for example #19, which needs ai-openshell/openshell#4956).

Related Issue

Part of ai-openshell/openshell#5480. Unblocks #19 without waiting for v0.1.10-pre.3.

Changes

  • scripts/e2e/start-gateway.sh: accept a full SHA and run the dev images core publishes for it. Core's release-dev.yml tags gateway, supervisor, and sandbox images with the full commit SHA, but builds batches of main commits, so the error says so when a commit has no images.
  • scripts/core-sync/core-tags.sh: for a SHA pin, the newer tags are the release tags that contain the commit, found with the GitHub compare API from the newest tag down. Tag pins behave as before.
  • scripts/core-sync/open-bump-pr.sh: bump from a SHA pin; the proto diff fetches the commit.
  • scripts/core-sync/drift-check.sh: run buf breaking against the pinned commit.
  • Releases stay stable-tag only: tag-release.sh already ignores other pins; its comment now says so.
  • Document SHA pins in CONTRIBUTING.md (Bindings and core versions), scripts/README.md, the mise.toml comment, and the e2e.yml input.

The scripts shared with sdk-python and the draft shared core-sync (ai-openshell/workflows#3) are not changed here.

Testing

  • E2E on this branch against core 90e34ad10 (dev images): run 44650913816, 10 tests passed.
  • core-tags.sh with tag pins v0.1.9 and v0.1.8 prints the same as main. With SHA pins: 90e34ad10 → none (no tag contains it yet); the parent of v0.1.10-pre.1 → v0.1.10-pre.1, v0.1.10-pre.2; the parent of v0.1.9 → v0.1.9-pre.5 and later. A short SHA is rejected.
  • open-bump-pr.sh v0.1.10-pre.1 --dry-run from a base pinned to a SHA: builds the proposal, links the compare from the SHA, and diffs protos.
  • drift-check.sh with a SHA pin: pass.
  • mise run workflows:check (actionlint, zizmor, shellcheck) and mise run format:check pass.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • README or CONTRIBUTING.md updated (if applicable)

SDK support for a proto change that is on core's main but in no core tag
yet (ai-openshell/openshell#4956) can't pass CI until the next core prerelease.
Accept a full commit SHA in OPENSHELL_CORE_REF besides release tags.

- start-gateway.sh runs the dev images core publishes per commit
  (release-dev.yml tags them with the full SHA). Dev builds cover batches
  of main commits, so the error names that when a commit has none.
- core-tags.sh treats the release tags that contain the pinned commit as
  newer, using the GitHub compare API from the newest tag down.
- open-bump-pr.sh bumps from a SHA pin and diffs protos from the commit.
- drift-check.sh compares main against the commit with buf breaking.
- Releases stay stable-tag only: tag-release.sh already ignores other pins.

Document SHA pins in CONTRIBUTING.md and scripts/README.md.

Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
@pimlock
pimlock requested review from a team as code owners November 20, 2026 01:06

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant