-
Notifications
You must be signed in to change notification settings - Fork 0
fix: normalize Gemini schemas for non-native transports #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
byapparov
wants to merge
5
commits into
main
Choose a base branch
from
backport/gemini-schema
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
6eca2e3
fix: normalize Gemini schema type arrays
byapparov 0e459de
fix: preserve Gemini schema combiners
byapparov de24fcb
fix: defer Gemini unions to native adapters
byapparov aff0dd3
fix(provider): preserve Gemini schema members and constraints
byapparov c565677
fix(provider): preserve constraints when splitting Gemini unions
byapparov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Null-only type array emits bare type:"null".
🤖 Fix with your agent
Why this matters
When a type array contains only "null" (e.g.
type: ["null"]), the non-native split setsresult.type = "null". Gemini's Schema.type enum has no NULL value — nullability is expressed vianullable, which is exactly what every other branch in this same block does (anyOf +nullable: true). On the non-native transports this PR targets precisely because their translation layer does not normalize, a bare{type:"null"}node is invalid on the wire (or coerced to TYPE_UNSPECIFIED). Not a regression (pre-PR sent["null"]raw, equally invalid), but the rewrite should match the convention it establishes everywhere else. The "collapses a null-only type array" test pins the current shape.