fix(layout): make a table cell reach the foot of a drawing placed in it - #345
Merged
Merged
Conversation
A picture or drawing placed top and bottom or wrapped square from a cell paragraph that holds no text, not set as a character, makes the cell reach its foot, its outer margins included, and the row grows to hold it; the paragraph's own line stays at its top. It was left out, the row one line tall. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ects-in-table-cells # Conflicts: # src/hwpx/layout/pages.py
Owner
Author
|
main(7c6606c)을 합쳤습니다(b8b312d). 충돌은 🤖 Generated with Claude Code |
# Conflicts: # tests/test_layout_page_estimate.py
…ects-in-table-cells # Conflicts: # CHANGELOG.md
Owner
Author
# Conflicts: # tests/test_layout_page_estimate.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
바뀐 점
쪽 수 추정(실험,
estimate_pages)이 표 칸 안에 둔 그림·도형의 높이를 행 높이에 넣는다._Measure.stack()이 칸 문단마다_objects_reach()로 개체의 아래 끝을 구하고, 줄보다 낮으면 그 높이를 쓴다. 표를 글자처럼 둔 경우와 흐르는 경우 모두 그렇다.테스트
tests/test_layout_page_estimate.pyHANCOM_PAGES에 더한다. 모두 2×2 표의 첫 칸 문단에 글 없이 개체만 둔 것이다.고치기 전 코드에서는 새 테스트 12개가 모두 실패한다.
🤖 Generated with Claude Code