fix(layout): follow a table offset down from a line at a page end - #346
Merged
Merged
Conversation
A table flowing top and bottom, offset down from the first line of a paragraph of text: when that line does not fit above the page's foot it goes on to the next page with its table, which flows the offset below it there; when the line fits but the table's top falls past the foot, or its first row moved row by row does not fit under it, the table starts at the next page's top while the paragraph's lines go on under its line, below the table on the pages it takes. All three were not followed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # tests/test_layout_page_estimate.py
…set-table-at-a-page-end # Conflicts: # CHANGELOG.md # src/hwpx/layout/pages.py
Owner
Author
# Conflicts: # tests/test_layout_page_estimate.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
바뀐 점
쪽 수 추정(실험,
estimate_pages)이 글 문단의 첫 줄에서 아래로 띄운 흐르는 위아래 표를 쪽 끝에서도 따른다. 전에는 아래 세 경우 모두 지원 밖(a top-and-bottom table offset down from a line at a page end)이었다._banded()가_next_frame()으로 줄을 다음 쪽에 두고 나서 띠를 잡는다. 흐르는 표만 든 문단의_flow()와 같은 모양이다._band_on_next_page()가 표가 차지하는 쪽을 잡아 두고(reserved) 문단의 줄을 놓는다. 흐르는 표가 앵커 다음 쪽에서 시작할 때의_starts_next_page()와 같은 방식이다.테스트
tests/test_layout_page_estimate.pyHANCOM_PAGES에 더한다. 모두 3행 표를 한 줄짜리 글 문단의 윗선에서 아래로 띄운 것이다.고치기 전 코드에서는 새 테스트 6개가 모두 실패한다.
🤖 Generated with Claude Code