Repository navigation
Docs/minor fixes 2 - #361
Merged
Merged
Conversation
ipmach
reviewed
Oct 13, 2026
ipmach
left a comment
ipmach
left a comment
Contributor
There was a problem hiding this comment.
Looks good, but we are going to have some merge issues, #364 and the current version.
#364 adds a more detail alert aggregation documentation and new alert aggregator methods. Maybe we can merge first that one and after this one to reduce merging issues.
Specially because yours definitions are better, so I think it will be easier to overwrite the ones of the other PR
Follow the schema field rename (#363) in the docs changes, keep the config Field descriptions and add one for deduplicate_values, and regenerate the configuration argument tables. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
@thorinaboenke I added the merge from the other PR, if you are ok with that feel free to merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed inaccurate claims in the docs: detector descriptions, template matcher behavior, and the log formats
Converted plain-text notes and warnings into proper boxes
Basic Concat page now uses the standard structure (YAML config, generated arguments table)
Fixed the Event Sequence example output (empty logID)
Updated the contribution guide (bug report template) and fixed typos
Code: exported PersistencySaveError, added field descriptions to the alert aggregator configs
This Pull-Request goes to the development branch.
I have successfully run prek locally.
I have added tests to cover my changes.
I have linked the issue-id to the task-description.
I have performed a self-review of my own code.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.