fix(contract): sync quota lifetime response - #61
Merged
Merged
Conversation
Rationale: The generated QuotaInfo response schema rejected Production's valid lifetime grant entries after the server-side quota snapshot fix, turning HTTP 200 quota reads into client contract errors. The canonical snapshot now matches the producer's scope and lifetime-grant fields.\n\nRejected: A raw-response fallback or permissive decoder would hide producer/consumer drift and discard the metric-scope identity.\n\nTested: bun run test -- test/generated-command.test.ts --testNamePattern='quotas.list accepts a lifetime quota response'; mise run generate:check; mise run check; bun run test; jq QuotaInfo producer/CLI equality check; independent review (no blockers).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale: The generated QuotaInfo response schema rejected Production's valid lifetime grant entries after the server-side quota snapshot fix, turning HTTP 200 quota reads into client contract errors. The canonical snapshot now matches the producer's scope and lifetime-grant fields.\n\nRejected: A raw-response fallback or permissive decoder would hide producer/consumer drift and discard the metric-scope identity.\n\nTested: bun run test -- test/generated-command.test.ts --testNamePattern='quotas.list accepts a lifetime quota response'; mise run generate:check; mise run check; bun run test; jq QuotaInfo producer/CLI equality check; independent review (no blockers).