test(cli): cover custom-method path regressions - #64
Open
robinbraemer wants to merge 1 commit into
Open
robinbraemer wants to merge 1 commit into
robinbraemer wants to merge 1 commit into
Conversation
Rationale: The system-level URL template fix is already on main, but Product Quality found that the released CLI still crashes specifically on operations.wait. Pin the exact action path and its nested counterpart so a future generated-client or Effect patch cannot reinterpret literal custom-method suffixes as parameters.\n\nRejected: Changing generated code again would duplicate the already-merged path compiler correction.\n\nTested: bun run test -- test/generated-command.test.ts --testNamePattern='operations\.wait|refreshCapabilities'; mise run check; git diff --check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds behavioural generated-command coverage for the two literal custom-method paths named in CNAP Product Quality issue akua-dev/cnap#1761:
POST /operations/{id}:wait, including an encoded path id andtimeoutquery.POST /clusters/{id}/capabilities:refresh, including its nested literal suffix and headers.The path compiler fix itself is already merged in #55. This PR keeps the regression contract at the actual generated-command boundary; it does not duplicate that implementation change.
Verification
bun run test -- test/generated-command.test.ts --testNamePattern='operations\.wait|refreshCapabilities'mise run check— build, generation drift check, 19 files / 188 testsgit diff --checkDelivery note
The released
v0.10.1remains affected because it predates #55. Publishing the fixed source is independently blocked by governed Release Please tag identity in #63; no manual release workaround is included here.