Repository navigation
Conversation
Self-signed fork releases need --signed without a Developer ID team id or provisioning profile. Skip passkeys and notarization in that case, keep the upstream passkey path when those env vars are set, and remap Blacksmith CI runners on this fork. Co-authored-by: amartya18 <amartya18@users.noreply.github.com>
ubuntu-latest is Ubuntu 26, and Playwright 1.60 cannot install chromium-headless-shell there. Pin the fork remap to ubuntu-24.04 and format the new desktop artifact tests so vp check passes. Co-authored-by: amartya18 <amartya18@users.noreply.github.com>
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: unavailable · PR result: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
…sage retention Storage cleanup treated a missing gitdir as a branch change; Git 2.56 on GitHub-hosted runners fatals instead. The usage "windows it reaches" fixture used 2026-08-01, which is older than the 92-day cache retention as of November 2026. Neither change is fork product behavior. Co-authored-by: amartya18 <amartya18@users.noreply.github.com>
Date.now in the 92-day usage retention test trips t3code/no-wall-clock-in-tests. Read the live clock through Effect Clock instead. Self-signed --signed mac builds now force code signing, keep notarize off, and embed hardened-runtime entitlements (JIT, disable-library-validation, camera, microphone) without Apple team or associated-domain claims. Co-authored-by: amartya18 <amartya18@users.noreply.github.com>
This was referenced Nov 2, 2026
Clock.currentTimeMillis cleared the wall-clock lint, but typecheck still rejects new Date() in Effect tests. Use DateTime.makeUnsafe/formatIso for the UTC day and transcript timestamp. Co-authored-by: amartya18 <amartya18@users.noreply.github.com>
The Check job only failed because Test Web hit a pre-existing AttachmentFilePreview timeout. PR 14 already passed the same suite on this stack. Co-authored-by: amartya18 <amartya18@users.noreply.github.com>
GitHub-hosted ubuntu-24.04 paints the workspace PDF slower than Blacksmith 8vcpu, so the scroll/zoom test missed 1 / 3 pages inside the 15s default. Wait 30s for that label and give the test 60s. Co-authored-by: amartya18 <amartya18@users.noreply.github.com>
Lint forbids an unreasoned per-test timeout. Keep the 30s wait for 1 / 3 pages and a 60s ceiling so first paint can finish. Co-authored-by: amartya18 <amartya18@users.noreply.github.com>
Owner
Author
|
Closed by the owner: superseded by #17 and the new fork release setup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
This fork needs to ship signed macOS updates with a stable self-signed identity. Upstream
--signedalways required an Apple team id and provisioning profile, so a CSC_LINK-only build threw before electron-builder ran. Blacksmith runners also madeci.ymlunusable on the fork.Change
Skip passkey signing and notarization when
T3CODE_APPLE_TEAM_IDandT3CODE_MACOS_PROVISIONING_PROFILEare both unset. The existing passkey path still runs and still fails closed if either variable is set. Bundle id and user-data dir are unchanged.Self-signed
--signedmac builds now setmac.forceCodeSigning: trueand embed hardened-runtime entitlements (JIT, disable-library-validation, camera, microphone) without associated-domains.On this fork only,
ci.ymlandmobile-fingerprint-check.ymluse GitHub-hostedubuntu-24.04/macos-latest. pingdotgg keeps Blacksmith.Two v0.1.6 tests are adjusted so GitHub-hosted CI can go green: storage cleanup accepts Git 2.56's gitfile fatal, and the usage "windows it reaches" fixture stays inside the 92-day cache window via
Clock.currentTimeMillis(notDate.now()).PATCH.mdis the patch contract.Do not merge. After this lands, retarget #14 and #15 to
patches.