Skip to content

fix(desktop): sign macOS builds without Apple passkey profiles - #13

Closed
amartya18 wants to merge 8 commits into
patchesfrom
agentc/release-plumbing-9b2f
Closed

amartya18 wants to merge 8 commits into
patchesfrom
agentc/release-plumbing-9b2f

Conversation

@amartya18

@amartya18 amartya18 commented Nov 2, 2026 •

Copy link
Copy Markdown
Owner

Problem

This fork needs to ship signed macOS updates with a stable self-signed identity. Upstream --signed always required an Apple team id and provisioning profile, so a CSC_LINK-only build threw before electron-builder ran. Blacksmith runners also made ci.yml unusable on the fork.

Change

Skip passkey signing and notarization when T3CODE_APPLE_TEAM_ID and T3CODE_MACOS_PROVISIONING_PROFILE are both unset. The existing passkey path still runs and still fails closed if either variable is set. Bundle id and user-data dir are unchanged.

Self-signed --signed mac builds now set mac.forceCodeSigning: true and embed hardened-runtime entitlements (JIT, disable-library-validation, camera, microphone) without associated-domains.

On this fork only, ci.yml and mobile-fingerprint-check.yml use GitHub-hosted ubuntu-24.04 / macos-latest. pingdotgg keeps Blacksmith.

Two v0.1.6 tests are adjusted so GitHub-hosted CI can go green: storage cleanup accepts Git 2.56's gitfile fatal, and the usage "windows it reaches" fixture stays inside the 92-day cache window via Clock.currentTimeMillis (not Date.now()).

PATCH.md is the patch contract.

Do not merge. After this lands, retarget #14 and #15 to patches.

Open in Web Open in Cursor 

Self-signed fork releases need --signed without a Developer ID team
id or provisioning profile. Skip passkeys and notarization in that
case, keep the upstream passkey path when those env vars are set,
and remap Blacksmith CI runners on this fork.

Co-authored-by: amartya18 <amartya18@users.noreply.github.com>
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L labels Nov 2, 2026
ubuntu-latest is Ubuntu 26, and Playwright 1.60 cannot install
chromium-headless-shell there. Pin the fork remap to ubuntu-24.04
and format the new desktop artifact tests so vp check passes.

Co-authored-by: amartya18 <amartya18@users.noreply.github.com>
@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire — 5.0 KiB — 6.8 KiB ✅
Codex Thread snapshot wire — 3.8 KiB — 4.9 KiB ✅
Codex Live turn WebSocket wire — 1.3 KiB — 2.0 KiB ✅
Codex Live turn WebSocket decoded — 21.6 KiB — 24.4 KiB ✅
Codex Live turn messages — 2 — 8 ✅
Claude Total thread wire — 5.0 KiB — 6.8 KiB ✅
Claude Thread snapshot wire — 3.8 KiB — 4.9 KiB ✅
Claude Live turn WebSocket wire — 1.3 KiB — 2.0 KiB ✅
Claude Live turn WebSocket decoded — 21.9 KiB — 24.4 KiB ✅
Claude Live turn messages — 2 — 8 ✅

Baseline: unavailable · PR result: 3b32ec0 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 108.5 KiB
  • Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

cursoragent and others added 2 commits November 2, 2026 11:37
…sage retention

Storage cleanup treated a missing gitdir as a branch change; Git 2.56 on
GitHub-hosted runners fatals instead. The usage "windows it reaches"
fixture used 2026-08-01, which is older than the 92-day cache retention
as of November 2026. Neither change is fork product behavior.

Co-authored-by: amartya18 <amartya18@users.noreply.github.com>
Date.now in the 92-day usage retention test trips t3code/no-wall-clock-in-tests.
Read the live clock through Effect Clock instead.

Self-signed --signed mac builds now force code signing, keep notarize off, and
embed hardened-runtime entitlements (JIT, disable-library-validation, camera,
microphone) without Apple team or associated-domain claims.

Co-authored-by: amartya18 <amartya18@users.noreply.github.com>
cursoragent and others added 4 commits November 2, 2026 11:55
Clock.currentTimeMillis cleared the wall-clock lint, but typecheck still
rejects new Date() in Effect tests. Use DateTime.makeUnsafe/formatIso for
the UTC day and transcript timestamp.

Co-authored-by: amartya18 <amartya18@users.noreply.github.com>
The Check job only failed because Test Web hit a pre-existing
AttachmentFilePreview timeout. PR 14 already passed the same suite on
this stack.

Co-authored-by: amartya18 <amartya18@users.noreply.github.com>
GitHub-hosted ubuntu-24.04 paints the workspace PDF slower than
Blacksmith 8vcpu, so the scroll/zoom test missed 1 / 3 pages inside
the 15s default. Wait 30s for that label and give the test 60s.

Co-authored-by: amartya18 <amartya18@users.noreply.github.com>
Lint forbids an unreasoned per-test timeout. Keep the 30s wait for
1 / 3 pages and a 60s ceiling so first paint can finish.

Co-authored-by: amartya18 <amartya18@users.noreply.github.com>
@amartya18

Copy link
Copy Markdown
Owner Author

Closed by the owner: superseded by #17 and the new fork release setup.

@amartya18 amartya18 closed this Nov 5, 2026
@amartya18
amartya18 deleted the agentc/release-plumbing-9b2f branch November 5, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants