Skip to content

Mark request URIs and form file paths as Psalm taint sinks - #402

Merged
trowski merged 2 commits into
amphp:5.xfrom
danog:taint-annotations
Nov 9, 2026
Merged

trowski merged 2 commits into
amphp:5.xfrom
danog:taint-annotations

Conversation

@danog

@danog danog commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Psalm doesn't analyse vendor code, so its taint analysis can't see that a user-controlled URI ends up in an outgoing request. This marks the $uri of Request::__construct() and Request::setUri() as ssrf sinks, and the local $path of Form::addFile() as a file sink.

https://claude.ai/code/session_016B9dWRw6Lako9sXAWMtWAx

@trowski
trowski merged commit e8fc84b into amphp:5.x Nov 9, 2026
8 checks passed
@trowski

trowski commented Nov 9, 2026

Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants