Repository navigation
Add Request::setConnectCallback() to check addresses before connecting - #408
Closed
nicolas-grekas wants to merge 1 commit into
Closed
nicolas-grekas wants to merge 1 commit into
nicolas-grekas wants to merge 1 commit into
Conversation
The callback is called with the IP address of each connection attempt, before the connection is opened.
Contributor
Author
|
Not needed anymore, see amphp/socket#122. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a per-request callback that's called with the IP address of each connection attempt, before the connection is opened.
SSRF filters need to check the resolved address before connecting, and
EventListener::connectionAcquired()comes too late for that.A request that has a callback reuses only the pooled connections opened with the same callback.
This needs
ConnectContext::withConnectCallback()from amphp/socket#122, hence the^2.5constraint.