Repository navigation
image: Write complete UAPI.16 sequences - #409
Open
daandemeyer wants to merge 1 commit into
Open
daandemeyer wants to merge 1 commit into
daandemeyer wants to merge 1 commit into
Conversation
martinpitt
reviewed
Nov 16, 2026
daandemeyer
force-pushed
the
push-wuwzxxnzsymy
branch
from
November 16, 2026 14:20
6ef3118 to
4660cfc
Compare
martinpitt
approved these changes
Nov 16, 2026
martinpitt
left a comment
Member
There was a problem hiding this comment.
Thanks! The updated digests are in, so please push them and 🚀
The manifest uses the wrong timestamp field and lacks the trailer that marks a complete sequence. Let's use mTimeNSec and require the trailer in readers and writers. Let's also sort the keys of each record so the bytes don't depend on insertion order, and fail on unnormalized names and on mtimes before 1970, which the format can't represent. Finally, let's move the format out of the image driver into a uapi16 package of its own. Other packages can then read and write manifests without depending on image/. Signed-off-by: Daan De Meyer <daan@amutable.com>
daandemeyer
force-pushed
the
push-wuwzxxnzsymy
branch
from
November 16, 2026 15:58
4660cfc to
930deb2
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The manifest uses the wrong timestamp field and lacks the trailer that
marks a complete sequence. Let's use mTimeNSec and require the trailer in
readers and writers. Let's also sort the keys of each record so the bytes
don't depend on insertion order, and fail on unnormalized names and on
mtimes before 1970, which the format can't represent. Finally, let's move
the format out of the image driver into a uapi16 package of its own.
Other packages can then read and write manifests without depending on
image/.
Signed-off-by: Daan De Meyer daan@amutable.com