Skip to content

image: Write complete UAPI.16 sequences - #409

Open
daandemeyer wants to merge 1 commit into
amutable:mainfrom
daandemeyer:push-wuwzxxnzsymy
Open

daandemeyer wants to merge 1 commit into
amutable:mainfrom
daandemeyer:push-wuwzxxnzsymy

Conversation

@daandemeyer

Copy link
Copy Markdown
Member

The manifest uses the wrong timestamp field and lacks the trailer that
marks a complete sequence. Let's use mTimeNSec and require the trailer in
readers and writers. Let's also sort the keys of each record so the bytes
don't depend on insertion order, and fail on unnormalized names and on
mtimes before 1970, which the format can't represent. Finally, let's move
the format out of the image driver into a uapi16 package of its own.
Other packages can then read and write manifests without depending on
image/.

Signed-off-by: Daan De Meyer daan@amutable.com

Comment thread image/BUCK Resolved
Comment thread docs/design/architecture.md Resolved
Comment thread image/manifest_main.py Resolved
Comment thread examples/image/expected.json Resolved

@martinpitt martinpitt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The updated digests are in, so please push them and 🚀

The manifest uses the wrong timestamp field and lacks the trailer that
marks a complete sequence. Let's use mTimeNSec and require the trailer in
readers and writers. Let's also sort the keys of each record so the bytes
don't depend on insertion order, and fail on unnormalized names and on
mtimes before 1970, which the format can't represent. Finally, let's move
the format out of the image driver into a uapi16 package of its own.
Other packages can then read and write manifests without depending on
image/.

Signed-off-by: Daan De Meyer <daan@amutable.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants