Repository navigation
fix(bedrock/aws/vertex): raise CredentialsError when credentials missing (#2038) - #2039
Open
mangeshraut712 wants to merge 4 commits into
Open
mangeshraut712 wants to merge 4 commits into
mangeshraut712 wants to merge 4 commits into
Conversation
Replace bare RuntimeError with anthropic.CredentialsError (an AnthropicError subclass) when AWS session credentials or a Vertex API token cannot be resolved, so callers can catch configuration failures with except AnthropicError. Keeps the previous message text. Fixes anthropics#2038.
Exercise Vertex tokenless refresh and Bedrock missing credentials for sync and async stable and beta message requests. Assert CredentialsError, preserve exact messages, and block provider HTTP. Replace the private Bedrock helper regression with public request-path tests.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When Bedrock/AWS session credentials or a Vertex API token cannot be resolved, the clients raised a bare
RuntimeError. That is not ananthropic.AnthropicError, so callers (and frameworks wrapping the SDK) could not classify a missing-credentials configuration failure.Raise the existing
CredentialsErrorinstead, keeping the previous message text.Test plan
tests/lib/test_aws_auth.py::TestGetAuthHeaders::test_raises_on_missing_credentialsnow expectsCredentialsErrortests/lib/test_bedrock_auth.pycovering the Bedrock auth pathFixes #2038