Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2055
Records
gen_ai.response.finish_reasonsbesideanthropic.message.stop_reasonwhen the response has a stop reason. Also stops settingStatusCode.OKon successful spans, following the OpenTelemetry guidance to leave span status unset unless there is an error.This applies to API calls, streamed bodies, work spans, tool-runner spans, and tool-use spans. Tests now assert
UNSETon success and the new finish-reasons attribute.Verification
uv run pytest tests/test_open_telemetry.py tests/lib/tools/test_open_telemetry.py tests/lib/environments/test_poller_method.py tests/lib/environments/test_worker.py -q -n0: 1085 passed, 4 skipped./scripts/lint: ruff, dependency caps, pyright and import check passed