Repository navigation
fix: split fork transcripts on newline only - #1445
Open
mangeshraut712 wants to merge 6 commits into
Open
mangeshraut712 wants to merge 6 commits into
mangeshraut712 wants to merge 6 commits into
Conversation
Author
|
Friendly bump — CI is green and this is ready for review when you have a minute. Happy to adjust anything. |
Author
|
Still green and ready for review/merge when you have a moment. |
Author
|
This is mergeable and ready for review. It splits fork transcripts on newline only so partial lines are not treated as complete events. Happy to take any feedback — if it looks good, could you please review and merge when you get a chance? Thanks. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_parse_fork_transcriptusedstr.splitlines(), which also splits on U+2028 / U+2029 / U+0085 inside JSON string values. That dropped transcript entries and brokeparentUuidchains on fork.Split JSONL records on
"\n"only (the actual record separator).Fixes #1441
Test plan
pytest tests/test_session_mutations.py(53 passed)