Repository navigation
fix(mcp): reject duplicate SDK tool names - #1473
Open
Linxiushen wants to merge 1 commit into
Open
Linxiushen wants to merge 1 commit into
Linxiushen wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When two SDK tools share a name,
tools/listcurrently exposes both descriptions and annotations while the schema and handler maps silently use the last tool. This can pair one tool's advertised metadata with another tool's implementation.Reject duplicate names in
create_sdk_mcp_serverwith aValueErrornaming the conflict. Names remain case-sensitive and scoped to each server. Add construction regressions plus real in-memory MCP tests for distinct case-sensitive names and reuse across servers.Validation: the new duplicate cases fail on the unchanged runtime; Windows MCP integration 146 passed; full Linux suite 1647 passed / 6 skipped; Ruff check/format and mypy pass. Both async backends run, with MCP 2.3.0; no live Claude request was required.