Skip to content

Add horizontal scroll and custom button to 4.0.0 Monitor - #6579

Open
Amemeda wants to merge 11 commits into
apache:mainfrom
Amemeda:6546-monitor-updates
Open

Amemeda wants to merge 11 commits into
apache:mainfrom
Amemeda:6546-monitor-updates

Conversation

@Amemeda

@Amemeda Amemeda commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator

Updated server_process_common.js:

  • New custom button "Reset" added per DataTable next to the Column Selection Dropdown (gear icon). This button resets stored column ordering and column selection.
  • Added the ability for a DataTable to have a horizontal scroll bar. It applies to all DataTables, but will only display on tables that are too wide for the screen display. The following pages contain tables that are now horizontally scrollable:
    Servers: Compactors
    Servers: Managers
    Servers: Scan Servers
    Servers: Tablet Servers
    Activity: Compaction Overview

Display of horizontal scroll and Reset button

Screenshot of Compaction Overview, showing the horizontal scroll bar active on Compaction Coordinator Activity table, and the position of the new reset button:

image

Reset button includes hover text:

image

Sample of using Reset button

  1. Using the existing Column Selection Dropdown, I have deselected "Last Contact" column (1st column) which removes it from the table, I have also dragged and moved "Resource Group" to a different order in the table (4th column).
image
  1. I press the Reset button, "Last Contact" column is now selected again and visible as 1st column, and "Resource Group" is moved back to its original order of 2nd column.
image __________________________________________________________________________________________________________________________

This pr closes #6546

@Amemeda
Amemeda marked this pull request as ready for review October 6, 2026 18:04
@Amemeda Amemeda changed the title Add horizontal scroll and custom button to 4.0 Monitor Add horizontal scroll and custom button to 4.0.0 Monitor Oct 13, 2026
@Amemeda
Amemeda requested a review from DomGarguilo October 20, 2026 16:32

@DomGarguilo DomGarguilo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticing a few issues here

  1. The header and body border for the tables are misaligned now. The screenshots you attached to this PR show that.
  2. scrolling jumps back to the left on every auto-refresh. this makes the new scrolling feature almost unusable. We probably need to save the scroll position before destroy() and restore it after the DataTable rebuilds. I have not looked into this much so there may be other/better ways to do this too
  3. The reset button tooltip says "Reset column selection and order" which users could get confused with the sort order of the columns. Maybe the tooltip can be more specific and say it resets the "column order"

@DomGarguilo

Copy link
Copy Markdown
Member

2. scrolling jumps back to the left on every auto-refresh. this makes the new scrolling feature almost unusable. We probably need to save the scroll position before destroy() and restore it after the DataTable rebuilds. I have not looked into this much so there may be other/better ways to do this too

Looking at the code here, I think it would be possible to fix this by avoiding rebuilding the datatable if the columns definition coming from the server does not change. Since the columns will only change when the server code is recompiled its very unlikely it will change during runtime anyway. That way we can avoid doing a lot of work of rebuilding the datatable and it also has the benefit of not resetting the scroll position and just refreshes the data in the table.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4.0 Monitor - Data Tables

3 participants