Repository navigation
Conversation
DomGarguilo
left a comment
There was a problem hiding this comment.
Noticing a few issues here
- The header and body border for the tables are misaligned now. The screenshots you attached to this PR show that.
- scrolling jumps back to the left on every auto-refresh. this makes the new scrolling feature almost unusable. We probably need to save the scroll position before
destroy()and restore it after the DataTable rebuilds. I have not looked into this much so there may be other/better ways to do this too - The reset button tooltip says "Reset column selection and order" which users could get confused with the sort order of the columns. Maybe the tooltip can be more specific and say it resets the "column order"
Looking at the code here, I think it would be possible to fix this by avoiding rebuilding the datatable if the columns definition coming from the server does not change. Since the columns will only change when the server code is recompiled its very unlikely it will change during runtime anyway. That way we can avoid doing a lot of work of rebuilding the datatable and it also has the benefit of not resetting the scroll position and just refreshes the data in the table. |
Updated
server_process_common.js:Servers: Compactors
Servers: Managers
Servers: Scan Servers
Servers: Tablet Servers
Activity: Compaction Overview
Display of horizontal scroll and Reset button
Screenshot of Compaction Overview, showing the horizontal scroll bar active on Compaction Coordinator Activity table, and the position of the new reset button:
Reset button includes hover text:
Sample of using Reset button
This pr closes #6546