Repository navigation
Conversation
The test was moved to the server module in apache#5749 and moved back to core in apache#5865. When it was restored, the @test annotation was left off, so JUnit has not run it since. Put the annotation back so the main() output-file path of ClusterConfigParser is covered again, and pass the configuration file as Path.of(URL.toURI()) like the other tests, since URL.getFile() is URL-encoded.
DomGarguilo
approved these changes
Oct 23, 2026
dlmarion
approved these changes
Oct 23, 2026
Contributor
|
@sharanggupta - Thanks for the contribution. Feel free to open a PR on the website repo if you want to add your name to the contributors list (https://github.com/apache/accumulo-website/blob/main/pages/people.md) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testShellOutputMainwas removed whenClusterConfigParserTestmoved to the server module in #5749. When #5865 moved the class back to core, the method came back without its@Testannotation, so JUnit has skipped it since. This puts the annotation back. The test checks thatClusterConfigParser.mainwrites the expected shell variables to the output file given as its second argument. It now passes the configuration file asPath.of(configFile.toURI()), like the other tests, becauseURL.getFile()is URL-encoded and would break on a path with spaces.mvn -pl core -am test -Dtest=ClusterConfigParserTest(JDK 21): 12 tests, 0 failures, withtestShellOutputMainnow among them. Formatter, impsort and checkstyle are clean.