Repository navigation
Conversation
Member
|
I think #6609 was suggesting increasing the wait for just the failing test case specifically instead of the default in Wait.java |
Collaborator
Author
|
Test is passing locally, @dlmarion do you think 60 milliseconds is a good increased wait time? should it be more? |
dlmarion
approved these changes
Oct 23, 2026
dlmarion
left a comment
dlmarion
left a comment
Contributor
There was a problem hiding this comment.
Changes look good. If 60s is not enough, then we can bump again.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix flaky test ResourceGroupConfigIT.testMultipleConfigurations by increasing wait time in the test from the default 30 milliseconds to 60 milliseconds.
Non issue but also applied code suggestion to change 3 similar wait conditions
cc.getServerPaths() .getCompactor(ResourceGroupPredicate.exact(first), AddressSelector.all(), true).size() == 0to checkisEmpty()instead of checking the size is 0.Closes issue #6609