[#2140] Widen MessageDatabase index-update points for subclasses - #2550
Open
mattrpav wants to merge 1 commit into
Open
[#2140] Widen MessageDatabase index-update points for subclasses#2550mattrpav wants to merge 1 commit into
mattrpav wants to merge 1 commit into
Conversation
…classes Continues apache#2140: updateIndex overloads (add, update, remove, remove-destination, subscription) and recordAckMessageReferenceLocation become protected, the TransactionIdConversion helpers become public, and Metadata gains lastUpdate accessors (nested-class fields are not reachable from a cross-package subclass of the outer class) so a KahaDBStore subclass supplied via createStore() can observe and apply index updates without copying store code. Visibility-only; no behavior change. The new javadoc on recordAckMessageReferenceLocation documents the existing index-lock guard on the ackMessageFileMap for subclass callers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change opens the possibility to extend KahaDB for performance improvements. Making architecture changes to KahaDB directly is considered risky, as KahaDB is very stable.
By supporting a subclassed KahaDB, developers and users may gradually rollout new KahaDB features and capabilities. Specifically, this relates to improving KahaDB throughput by being able to leverage modern JDK capabilities -- specifically Virtual Threads and aio.