Repository navigation
build(python/adbc_driver_manager): drop runtime dependency on typing-extensions - #5026
Merged
lidavidm merged 5 commits intoNov 13, 2026
Conversation
edgarrmondragon
marked this pull request as ready for review
November 12, 2026 06:40
edgarrmondragon
force-pushed
the
adbc-driver-manager-remove-typing-extensions
branch
from
November 12, 2026 06:42
c493b07 to
da27d1e
Compare
…extensions It's only needed for type checking and type checkers ship its stubs. Users who were getting `typing-extensions` only through adbc-driver-manager will no longer get it installed. Signed-off-by: Edgar Ramírez-Mondragón <edgarrm358@gmail.com>
edgarrmondragon
force-pushed
the
adbc-driver-manager-remove-typing-extensions
branch
from
November 12, 2026 06:42
da27d1e to
0b76acb
Compare
lidavidm
reviewed
Nov 12, 2026
| readme = "README.md" | ||
| requires-python = ">=3.11" | ||
| dynamic = ["version"] | ||
| dependencies = ["typing-extensions"] |
Member
There was a problem hiding this comment.
Can we move this to test? And place a python_version specifier on the requirement?
Contributor
Author
There was a problem hiding this comment.
Done in 28b1b39.
Also set the floor to >=4.12 since that's when CapsuleType was added.
FWIW, the dbapi and test extras could be made into dependency groups. That's probably out of scope here though.
Signed-off-by: Edgar Ramírez-Mondragón <edgarrm358@gmail.com>
Signed-off-by: Edgar Ramírez-Mondragón <edgarrm358@gmail.com>
Signed-off-by: Edgar Ramírez-Mondragón <edgarrm358@gmail.com>
lidavidm
approved these changes
Nov 13, 2026
edgarrmondragon
deleted the
adbc-driver-manager-remove-typing-extensions
branch
November 13, 2026 02:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's only needed for type checking, and type checkers ship its stubs. Users like me who were getting
typing-extensionsonly through adbc-driver-manager will no longer get it installed.ParamSpecandSelfwere added to the stdlib in Python 3.10 and 3.11, respectively, so it's safe to import them fromtypingunconditionally.types.CapsuleTypewas added in Python 3.13, so it's the only import that actually requirestyping-extensions.Closes #5025