Repository navigation
Conversation
adbc_clone() built the new Connection without passing autocommit, so a clone of a connection opened with autocommit=True ran in manual-commit mode and writes made through it were rolled back when it was closed. Pass autocommit, the connection options and the backend to the clone. Assisted-by: Claude Code (claude-opus-5-5)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connection.adbc_clone()builds the newConnectionwithout passingautocommit, so cloning a connection opened withautocommit=Truesilently turns autocommit off on the clone. Writes made through the clone are then rolled back when it is closed without an explicitcommit(), e.g. when such a connection is used as a pool factory viaadbc_cloneas in the connection pooling recipe.The clone now keeps the original's autocommit setting. It also keeps its connection options and backend, so cloning a clone behaves the same.
Closes #5032
This change was drafted with Claude Code (claude-opus-5-5); the test results above are from the runs described.