Repository navigation
ci: key workflow concurrency groups by pull request number - #1411
Merged
Merged
Conversation
The Lint, RC and Test workflows grouped runs by github.head_ref, which is only the branch name. Pull requests from different forks that use the same branch name therefore shared a group, and cancel-in-progress let each one cancel the other's runs (seen with apache#1406 and apache#1407, both from branches named fix/parquet-hidden-column-error). Use the pull request number instead; push events still fall back to github.sha as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The Lint, RC and Test workflows use
github.head_refis only the source branch name, without the fork owner. Two pull requests from different forks that happen to use the same branch name share a concurrency group, so each new run cancels the other PR's in-progress run.This happened with #1406 and #1407, both from branches named
fix/parquet-hidden-column-error: #1407's Test run cancelled a re-run of #1406's Test job partway through (run 39903724796, attempt 3:Test=cancelled, "The operation was canceled").What changes are included in this PR?
Key the group by
github.event.pull_request.numberinstead ofgithub.head_refinlint.yml,rc.ymlandtest.yml:pull_requestevents: one group per PR, so a new push to a PR still cancels that PR's older run, but different PRs no longer interfere.pushevents:pull_request.numberis empty, so the group falls back togithub.sha, unchanged from today.Are these changes tested?
actionlintaccepts all three workflows (its only reports are pre-existing shellcheck quoting notes inrun:scripts). This PR's own CI runs exercise the new groups.Are there any user-facing changes?
No.