Repository navigation
Move the Kamelets to Jackson 3 (camel-jackson3) - #3136
jamesnetherton wants to merge 2 commits into
Conversation
|
Claude Code on behalf of Claus Ibsen While documenting every Kamelet (#3140, #3141–#3155), each one was run on Camel 4.23.0 and on 4.24.0-SNAPSHOT. These Kamelets failed on 4.24 because of the Jackson 3 switch:
This PR changes all of them: the 90 Kamelets of One more case to check when the itests run on 4.24: The documentation PRs change the 🤖 Generated with Claude Code |
|
Thanks @davsclaus, this matches what we expected. The PR is a draft placeholder until the catalog moves to Camel 4.24.0, so the CI failures here are expected until then. I checked your findings locally, running this PR's Kamelets on a current Camel 4.24.0-SNAPSHOT build:
So the current catalog doesn't work on Camel 4.24, and this PR fixes that. CI here should go green once the catalog moves to Camel 4.24.0. Thanks for taking care of the docs PR rebases. Claude Code on behalf of James Netherton |
|
@jamesnetherton could you rebase this on Since this PR was opened,
After the rebase, run Claude Code on behalf of Claus Ibsen |
c79bccc to
0d01f3d
Compare
|
We are upgrading ahead of time to 4.24 and after a few other PRs merged then this should be ready for building and merging as well |
The parent camel-dependencies and camel.version move from 4.23.0 to 4.24.0-SNAPSHOT, so that the Kamelets can use what Camel main adds for 4.24, such as the schema registry options of camel-kafka (CAMEL-27130) for the Kafka Kamelets (apache#3183). The Apache snapshot repository is already configured. The catalog SBOM is regenerated with the Camel components at 4.24.0-SNAPSHOT. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@jamesnetherton the catalog is now ready for 4.24, and this PR is what #3186 needs to go green, so could you rebase it on top of #3186's branch ( What #3186's CI showed with Camel 4.24.0-SNAPSHOT:
With this PR on top of #3186, the Kamelets no longer bring camel-jackson, so the configurer clash should not happen even before CAMEL-27164 is in a snapshot. Once the Integration Tests are green, #3186 and this PR can be merged together. Several open #3170 PRs (#3192 to #3201) touch Kamelets that this PR also changes, so whichever merges later gets rebased. Claude Code on behalf of Claus Ibsen |
Camel 4.24 makes Jackson 3 (tools.jackson) the primary Jackson line (CAMEL-22857), and its camel-kamelet, camel-kafka transforms and the avro/protobuf schema resolvers move with it. Kamelets built on Jackson follow: - camel:jackson, camel:jackson-avro, camel:jackson-protobuf become camel:jackson3, camel:jackson3-avro, camel:jackson3-protobuf - unmarshalType com.fasterxml.jackson.databind.JsonNode becomes tools.jackson.databind.JsonNode - the avro/protobuf schema resolver beans use the jackson3 packages - the Jira Kamelets use tools.jackson.datatype:jackson-datatype-joda, now versioned from the Camel jackson3-version through the Kamelet version properties instead of a hardcoded 2.12.5 - azure-storage-blob-changefeed-source drops the JavaTimeModule registration: java.time support is built into Jackson 3 databind The catalog validator accepts camel:jackson3 as the leading dependency, the itests use camel-jackson3 and no longer exclude the Jackson 3 artifacts of citrus-validation-json, and the catalog SBOM is regenerated. The catalog library and the Maven plugin stay on Jackson 2: they parse the Kamelet YAML through the Fabric8-generated CRD model, which is Jackson 2 based. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
0d01f3d to
6e58917
Compare
|
@davsclaus done, this is now rebased on top of #3186's branch. Claude Code on behalf of James Netherton |
|
Thanks @jamesnetherton for the rebase. The only conflict left with Claude Code on behalf of Claus Ibsen |
Merges together with #3186. This branch is rebased on #3186 (
chore: build against Camel 4.24.0-SNAPSHOT), so until #3186 lands the diff here also shows its commit. Each PR needs the other: on 4.24 the current Kamelets bring camel-jackson next to Camel JBang's camel-jackson3, which breaks thejacksondata format, and this PR can only pass against a 4.24 build. Once #3186 is merged, this gets rebased onmainand only the Jackson 3 commit is left.Camel 4.24 makes Jackson 3 (
tools.jackson) the primary Jackson line (CAMEL-22857, apache/camel#29461). In Camel JBang thejson,avroJacksonandprotobufJacksondata formats resolve to Jackson 3, even when a Kamelet declarescamel:jackson, and theorg.apache.camel.component.kafka.transformclasses now work on a Jackson 3JsonNode. Kamelets that name Jackson 2 classes therefore fail on Camel 4.24. The 4.24 upgrade guide lists them under "Jackson 3 - camel-jackson3 is the Jackson line of the catalog, Camel JBang and the Kamelets".Changes:
camel:jackson,camel:jackson-avro,camel:jackson-protobufbecomecamel:jackson3,camel:jackson3-avro,camel:jackson3-protobufunmarshalType: com.fasterxml.jackson.databind.JsonNodebecomestools.jackson.databind.JsonNodejackson3packagestools.jackson.datatype:jackson-datatype-joda, versioned from the Cameljackson3-versionexamples/kamelets(bitcoin-source,earthquake-source,wttrin-source) get the same changecamel:jackson3; the itests usecamel-jackson3jackson-datatype-jodais 3.2.4, the Camel 4.24.0-SNAPSHOTjackson3-version, and the SBOM is regeneratedThe kafka transform class names do not change: Camel migrated them in place.
The catalog library and the Maven plugin stay on Jackson 2 (Fabric8 CRD model).
Claude Code on behalf of jamesnetherton
🤖 Generated with Claude Code