Repository navigation
Conversation
…an endpoint address A password, key or token placed into an endpoint address without RAW() is parsed as part of the URI, so a value with &, + or = is cut into another parameter or changed. Wrap every option with format password that goes into an address, as a query parameter or a parameters entry. KameletsSecretsRawTest checks every Kamelet, and HttpSinkSecretTest runs http-sink with a password that has those characters against a local server. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com>
Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com> # Conflicts: # kamelets/azure-functions-sink.kamelet.yaml # kamelets/azure-storage-blob-append-sink.kamelet.yaml # kamelets/azure-storage-blob-sink.kamelet.yaml # kamelets/azure-storage-datalake-sink.kamelet.yaml # kamelets/azure-storage-datalake-source.kamelet.yaml # kamelets/google-bigquery-sink.kamelet.yaml # kamelets/google-calendar-source.kamelet.yaml # kamelets/google-mail-source.kamelet.yaml # kamelets/google-pubsub-sink.kamelet.yaml # kamelets/google-pubsub-source.kamelet.yaml # kamelets/google-sheets-sink.kamelet.yaml # kamelets/google-sheets-source.kamelet.yaml # kamelets/google-storage-event-based-source.kamelet.yaml # kamelets/google-storage-sink.kamelet.yaml # kamelets/google-storage-source.kamelet.yaml # kamelets/google-vertexai-sink.kamelet.yaml # kamelets/infinispan-sink.kamelet.yaml # kamelets/infinispan-source.kamelet.yaml # kamelets/mail-sink.kamelet.yaml # library/camel-kamelets/src/main/resources/kamelets/azure-functions-sink.kamelet.yaml # library/camel-kamelets/src/main/resources/kamelets/azure-storage-blob-append-sink.kamelet.yaml # library/camel-kamelets/src/main/resources/kamelets/azure-storage-blob-sink.kamelet.yaml # library/camel-kamelets/src/main/resources/kamelets/azure-storage-datalake-sink.kamelet.yaml # library/camel-kamelets/src/main/resources/kamelets/azure-storage-datalake-source.kamelet.yaml # library/camel-kamelets/src/main/resources/kamelets/google-bigquery-sink.kamelet.yaml # library/camel-kamelets/src/main/resources/kamelets/google-calendar-source.kamelet.yaml # library/camel-kamelets/src/main/resources/kamelets/google-mail-source.kamelet.yaml # library/camel-kamelets/src/main/resources/kamelets/google-pubsub-sink.kamelet.yaml # library/camel-kamelets/src/main/resources/kamelets/google-pubsub-source.kamelet.yaml # library/camel-kamelets/src/main/resources/kamelets/google-sheets-sink.kamelet.yaml # library/camel-kamelets/src/main/resources/kamelets/google-sheets-source.kamelet.yaml # library/camel-kamelets/src/main/resources/kamelets/google-storage-event-based-source.kamelet.yaml # library/camel-kamelets/src/main/resources/kamelets/google-storage-sink.kamelet.yaml # library/camel-kamelets/src/main/resources/kamelets/google-storage-source.kamelet.yaml # library/camel-kamelets/src/main/resources/kamelets/google-vertexai-sink.kamelet.yaml # library/camel-kamelets/src/main/resources/kamelets/infinispan-sink.kamelet.yaml # library/camel-kamelets/src/main/resources/kamelets/infinispan-source.kamelet.yaml # library/camel-kamelets/src/main/resources/kamelets/mail-sink.kamelet.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3242.
A password, key or token that a Kamelet places into the address of the endpoint it calls is parsed as part of the URI. Without
RAW(), a value with&,+or=is cut into another parameter or changed: a passwordp&ss+w=rdlogs in asp, andhttp-sinkthen sendsss+w=rdas the query of the request. A Base64serviceAccountKeywith a+is changed the same way.Changes
format: passwordthat goes into an endpoint address, as a URI query parameter or aparametersentry, is wrapped inRAW()(31 Kamelets):http-sink/http-source(authPassword,oauth2ClientId,oauth2ClientSecret),mail-sink,cassandra-sink,infinispan-sink/-source, the Google Kamelets (serviceAccountKey,clientId), the Azure Storage Kamelets (tenantId,clientId), the Kafka Apicurio Kamelets,nats-sink/-source(servers),slack-sink(webhookUrl),ceph-event-based-sourceandazure-functions-sink(keyin thecodeparameter; withkeyInHeader=trueit is sent in a header instead).RAW({{?name}})is dropped like{{?name}}.Tests
KameletsSecretsRawTest: checks every Kamelet; an option withformat: passwordin an endpoint address withoutRAW()fails the build.HttpSinkSecretTest:http-sinkwith Basic login and the passwordp&ss+w=rdagainst a local server sends the whole password and no query. It fails onmain(the server getsquery=ss+w=rdand the login ofuser:p)../mvnw clean installpasses.Claude Code on behalf of Claus Ibsen
🤖 Generated with Claude Code