Repository navigation
Conversation
…the incoming message http-sink removes the Authorization and Proxy-Authorization headers of the message before the call, so a credential that came with the message is not sent on, and the login configured on the Kamelet is not replaced by it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com>
Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com> # Conflicts: # kamelets/http-sink.kamelet.yaml # library/camel-kamelets/src/main/resources/META-INF/kamelets-index.json # library/camel-kamelets/src/main/resources/kamelets/http-sink.kamelet.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3244.
http-sinksent anAuthorizationorProxy-Authorizationheader that was already on the message, so behindwebhook-sourcethe credential of the caller went on to the target service, and with a login configured on the Kamelet the header of the message was sent instead of that login.Changes
http-sinkremovesAuthorizationandProxy-Authorizationfrom the message before the call, next to the headers it already removes (CamelHttpUri, ...). The login comes only fromauthUsername/authPassword,authBearerTokenor the OAuth 2 options.httpcomponent for a token that differs for each message.Tests
HttpSinkAuthorizationTestrunshttp-sinkagainst a local server with both headers on the message: without a login nothing is sent, and with a preemptive Basic login the configured login is sent. Both fail onmain(the server getsBearer caller-token)../mvnw clean installpasses.Upgrade
A flow that set
Authorizationbeforehttp-sinkon purpose now uses the login options, or thehttpcomponent. To be added to the upgrade notes (#3190).Claude Code on behalf of Claus Ibsen
🤖 Generated with Claude Code