Repository navigation
chore: camel-launcher - the MCP plugin is embedded like the other plugins - #30127
Conversation
…gins
The jar of camel-jbang-plugin-mcp was in the launcher, but the plugin
was not in its list of embedded plugins. So camel mcp installed it on
first use ("Installed plugin: mcp", an entry in
~/.camel-jbang-plugins.json), and camel --help listed mcp under the
plugins that are not installed. Now the launcher adds its command as
it does for the other plugins.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com>
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
gnodet-bot
left a comment
There was a problem hiding this comment.
LGTM. The fix is minimal and correct — McpPlugin was already in the launcher classpath but absent from the embedded-plugin registry, causing it to behave as a downloadable plugin instead of a built-in. The registration entry and the two new test assertions cover both behaviors that were broken before this change.
This review was generated by an AI agent, Hermès on behalf of @gnodet.
|
🧪 CI tested the following changed modules:
🔬 Scalpel shadow comparison — Scalpel: 1 of 726 tested, 0 compile-only — current: 1 all testedMaveniverse Scalpel detected 1 affected modules (current approach: 1). Skip-tests mode would test 1 modules (1 direct + 1 downstream), skip tests for 0 (generated code, meta-modules) Modules Scalpel would test (1)
💡 Manual integration tests recommended:
All tested modules (2 modules, 1m 1s total)Total reactor time: 1m 1s
Top 20 slowest modules:
|
What
The Camel CLI distribution (
camel-launcher) has the jar ofcamel-jbang-plugin-mcp, butCamelLauncherMaindidn't list the plugin among its embedded plugins, next togenerate,kubernetes,tui,validateandtest. So:camel mcpinstalled it like a plugin to download: it printedInstalled plugin: mcpand wrote an entry to~/.camel-jbang-plugins.jsoncamel --helplistedmcpunder "Plugins (not installed)"Now
mcpis an embedded plugin, andcamel mcpcreates only its own command, as the other embedded plugins do since #28774. Nothing in the history (shallow) or JIRA says it was left out on purpose. It was never in the list, not even before #28774.A user whose
~/.camel-jbang-plugins.jsonalready hasmcpfrom an earliercamel mcpis not affected:PluginHelperskips a configured plugin whose command is already registered.Tests
CamelLauncherTest:camel mcp --helpcreates only themcpcommandcamel --helphas the commands of all embedded plugins, now withmcp,validateandtestBoth fail with the old
CamelLauncherMain.A launcher built from this branch, in a fresh home:
camel mcp --helpexits 0 with noInstalled pluginline and writes no plugin configuration, andcamel --helplistsmcpwith the commands.Claude Code on behalf of Claus Ibsen (davsclaus)
🤖 Generated with Claude Code