Skip to content

chore: camel-launcher - the MCP plugin is embedded like the other plugins - #30127

Merged
davsclaus merged 1 commit into
mainfrom
chore-launcher-embed-mcp
Nov 15, 2026
Merged

davsclaus merged 1 commit into
mainfrom
chore-launcher-embed-mcp

Conversation

@davsclaus

Copy link
Copy Markdown
Contributor

What

The Camel CLI distribution (camel-launcher) has the jar of camel-jbang-plugin-mcp, but CamelLauncherMain didn't list the plugin among its embedded plugins, next to generate, kubernetes, tui, validate and test. So:

  • the first camel mcp installed it like a plugin to download: it printed Installed plugin: mcp and wrote an entry to ~/.camel-jbang-plugins.json
  • camel --help listed mcp under "Plugins (not installed)"

Now mcp is an embedded plugin, and camel mcp creates only its own command, as the other embedded plugins do since #28774. Nothing in the history (shallow) or JIRA says it was left out on purpose. It was never in the list, not even before #28774.

A user whose ~/.camel-jbang-plugins.json already has mcp from an earlier camel mcp is not affected: PluginHelper skips a configured plugin whose command is already registered.

Tests

  • CamelLauncherTest:

    • camel mcp --help creates only the mcp command
    • camel --help has the commands of all embedded plugins, now with mcp, validate and test

    Both fail with the old CamelLauncherMain.

  • A launcher built from this branch, in a fresh home: camel mcp --help exits 0 with no Installed plugin line and writes no plugin configuration, and camel --help lists mcp with the commands.

Claude Code on behalf of Claus Ibsen (davsclaus)

🤖 Generated with Claude Code

…gins

The jar of camel-jbang-plugin-mcp was in the launcher, but the plugin
was not in its list of embedded plugins. So camel mcp installed it on
first use ("Installed plugin: mcp", an entry in
~/.camel-jbang-plugins.json), and camel --help listed mcp under the
plugins that are not installed. Now the launcher adds its command as
it does for the other plugins.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com>
@davsclaus davsclaus added this to the 4.24.0 milestone Nov 15, 2026
@davsclaus davsclaus added the dsl label Nov 15, 2026
@davsclaus davsclaus self-assigned this Nov 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run
  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
  • You can label PRs using skip-tests and test-dependents to fine-tune the checks executed by this PR.
  • Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@gnodet-bot gnodet-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The fix is minimal and correct — McpPlugin was already in the launcher classpath but absent from the embedded-plugin registry, causing it to behave as a downloadable plugin instead of a built-in. The registration entry and the two new test assertions cover both behaviors that were broken before this change.

This review was generated by an AI agent, Hermès on behalf of @gnodet.

@github-actions

Copy link
Copy Markdown
Contributor

🧪 CI tested the following changed modules:

  • dsl/camel-jbang/camel-launcher

🔬 Scalpel shadow comparison — Scalpel: 1 of 726 tested, 0 compile-only — current: 1 all tested

Maveniverse Scalpel detected 1 affected modules (current approach: 1).

Skip-tests mode would test 1 modules (1 direct + 1 downstream), skip tests for 0 (generated code, meta-modules)

Modules Scalpel would test (1)
  • camel-launcher-container ← downstream of org.apache.camel:camel-launcher

ℹ️ Shadow mode — Scalpel observes but does not affect test execution. Learn more

💡 Manual integration tests recommended:

You modified dsl/camel-jbang/camel-launcher. The related integration tests in dsl/camel-jbang/camel-jbang-it are excluded from CI. Consider running them manually:

mvn verify -f dsl/camel-jbang/camel-jbang-it -Djbang-it-test
All tested modules (2 modules, 1m 1s total)

Total reactor time: 1m 1s

Module Duration Status
Camel :: Launcher 59.9s SUCCESS
Camel :: Launcher :: Container 0.7s SUCCESS

Top 20 slowest modules:

  • Camel :: Launcher (59.9s)
  • Camel :: Launcher :: Container (0.7s)

⚙️ View full build and test results

@davsclaus davsclaus added the task label Nov 15, 2026
@davsclaus
davsclaus merged commit db50527 into main Nov 15, 2026
13 checks passed
@davsclaus
davsclaus deleted the chore-launcher-embed-mcp branch November 15, 2026 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants