Repository navigation
[CELEBORN-2463] Add ManuallyExcludedWorkerCount metric to distinguish manually excluded workers - #3848
Open
yew1eb wants to merge 1 commit into
Open
[CELEBORN-2463] Add ManuallyExcludedWorkerCount metric to distinguish manually excluded workers#3848yew1eb wants to merge 1 commit into
yew1eb wants to merge 1 commit into
Conversation
… manually excluded workers
Kalvin2077
approved these changes
Sep 16, 2026
afterincomparableyum
approved these changes
Sep 17, 2026
|
This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add a new master gauge metric
ManuallyExcludedWorkerCountthat reports the count of workers in the manually excluded list (statusSystem.manuallyExcludedWorkers.size).The existing
ExcludedWorkerCountmetric is kept unchanged (still the sum of both excluded and manually excluded workers) for backward compatibility.Why are the changes needed?
ExcludedWorkerCountcounts both workers excluded due to failure reports / unhealthy heartbeats, and workers excluded manually via the/excludeAPI during maintenance. As a result, alerts based onExcludedWorkerCountfire during routine maintenance even though the cluster is healthy.The two sets are already tracked separately internally (
excludedWorkersvsmanuallyExcludedWorkers) and exposed separately in the/workersAPI.With this PR, users can alert on
ExcludedWorkerCount - ManuallyExcludedWorkerCountto monitor only failure-driven exclusions.Does this PR resolve a correctness bug?
Does this PR introduce any user-facing change?
Add a new master metric
ManuallyExcludedWorkerCount.How was this patch tested?
Compiled the master module locally. The new gauge follows the exact same pattern as the existing
ExcludedWorkerCountgauge.