Fix project scoped network filtering during unmanaged instance import - #14008
Fix project scoped network filtering during unmanaged instance import#14008dheeraj12347 wants to merge 1 commit into
Conversation
|
Hi @DaanHoogland and @weizhouapache , quick update on the two PRs:
Please let me know if you’d like me to take any further action on either PR. Thanks! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.22 #14008 +/- ##
=========================================
Coverage 17.79% 17.80%
- Complexity 15995 15997 +2
=========================================
Files 5928 5928
Lines 534306 534309 +3
Branches 65383 65384 +1
=========================================
+ Hits 95069 95115 +46
+ Misses 428467 428420 -47
- Partials 10770 10774 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Description
Fix network selection for project-scoped unmanaged instance imports.
When importing an unmanaged instance from a project scope, the network selection component was not receiving the project ID. As a result,
listNetworkscould fall back to account/domain-based filtering instead of retrieving networks for the selected project.This change passes the project ID to
MultiNetworkSelectionand uses it when fetching networks.Changes
form.projectidfromImportUnmanagedInstance.vuetoMultiNetworkSelection.projectidas an optional prop toMultiNetworkSelection.projectidfor thelistNetworksAPI request when a project scope is selected.domainid+accountbehavior when no project ID is provided.Testing
git diff --checkpasses.Related
Fixes the project-scoped network selection issue during unmanaged instance import.