[oscerd]

The table at the top of the PatternOptionBuilder Javadoc has the descriptions of @ and + swapped. @ maps to Object and creates an instance of the named class through its no-argument constructor, while + maps to Class and only loads the class. PatternOptionBuilderTest.testSimplePattern already checks it that way (b@ gives a Vector, f+ gives Calendar.class), so only the docs were wrong.

Since someone reading the old table could pick @ thinking they just get a class name back, I also added a short note below the example and on Converter.OBJECT, Converter.CLASS, TypeHandler.createObject() and TypeHandler.createClass(): they load whatever class the value names (and @/OBJECT also runs its constructor), so they shouldn't be used on values from an untrusted source.

Javadoc only, no behavior change.

• Read the contribution guidelines for this project.
• Read the ASF Generative Tooling Guidance if you use Artificial Intelligence (AI).
• I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? Claude Code (Claude Opus 5.5) was used to analyze the issue and to prepare the change and this description.
• Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
• Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. Not applicable: Javadoc only.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.

🤖 Generated with Claude Code

[garydgregory]

@oscerd

Thanks for the update.

Could you adjust the Javadoc saying “options itself is not modified”? Parsing still changes option-group selections, so that’s a bit too broad. Or am I missing something?

Maybe: “Property values are added to the returned CommandLine without changing the values of the registered options.”

[oscerd]

You're right, sorry about that. Parsing still updates the option group selections, so that was too broad. The sentence is in #450, I've changed it there to your wording. Thanks!

[garydgregory]

Hi @oscerd
What do you think about my suggestions?

[oscerd]

Thanks, Suggestions merged

[garydgregory]

TY @oscerd , merged 🚀